Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add account deletion #202

Merged
merged 7 commits into from Feb 8, 2020
Merged

add account deletion #202

merged 7 commits into from Feb 8, 2020

Conversation

@robjloranger
Copy link
Member

robjloranger commented Oct 31, 2019

CLI only but backend supports calls from app.db.DeleteAccount already

takes --delete-account user_id_number with optional --posts to also
delete posts. if --posts is omitted all user posts will be updated to
anonymous posts

[Describe the pull request here...]


  • I have signed the CLA
CLI only but backend supports calls from app.db.DeleteAccount already

takes --delete-account user_id_number with optional --posts to also
delete posts. if --posts is omitted all user posts will be updated to
anonymous posts
@mrvdb
Copy link
Collaborator

mrvdb commented Nov 1, 2019

Nice! For writefreely hosters, this will be very useful to clean out their 'registered but nothing else'-users after a while.

@robjloranger
Copy link
Member Author

robjloranger commented Nov 1, 2019

After this we will likely be adding a nice button to each user page in the admin view as well

@thebaer
Copy link
Member

thebaer commented Nov 4, 2019

@robjloranger Haven't had a chance to run yet, but after reading through: let's have the --delete-account flag take a username instead of the user ID. Requiring the numeric ID isn't too user-friendly and I don't imagine it'll be used much. (Though I'm open to input -- any thoughts, @mrvdb?)

Also, let's have the default behavior delete all user posts -- I'm not sure people will want to leave user posts, especially because future deletion will require manual database work. Or was there a reason you had in mind for keeping posts?

@robjloranger
Copy link
Member Author

robjloranger commented Nov 4, 2019

@thebaer I had the option for posts because it was mentioned in the original task, probably more for write.as though. So for now I can just remove the option to keep posts.

this changed the CLI flag to use the username instead of the userID
leaving the underlying database function as is.

also now posts are all deleted with no option to skip as this is likely
never needed.
@robjloranger robjloranger mentioned this pull request Nov 5, 2019
1 of 1 task complete
@robjloranger robjloranger mentioned this pull request Nov 5, 2019
1 of 1 task complete
thebaer added 4 commits Feb 8, 2020
Previously, it would show a 500. This also logs the real reason if it's
not a "not found" error
@thebaer
Copy link
Member

thebaer commented Feb 8, 2020

I brought this up to date with develop and fixed a small issue I noticed in the admin panel after deleting a user. Otherwise this is good to go!

As mentioned in T319, this event needs to be federated. So I've created tasks for tackling that: T720 for posts and T721 for collections.

@thebaer thebaer added this to the 0.12 milestone Feb 8, 2020
@thebaer thebaer merged commit f8a40fa into develop Feb 8, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@thebaer thebaer deleted the T319-delete-account branch Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.