-
Notifications
You must be signed in to change notification settings - Fork 11
Implement responder chain in editor #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍 The Title field focus on load works perfectly!
One change I think we should implement, now that the title field auto-expands: add lineSpacing
to that text field.
Otherwise, in my testing, I noticed that pressing Return to move from Title to Body only works once. If that's a quick fix, I think we should fix it here. Otherwise it's not critical, so we can fix it another time.
🎉
Should be pretty straightforward. 👍
Good catch, I managed to repro this. I think I understand what's happening here, so I'll spend a little time this afternoon working on this; if possible, I'd like to push out another TestFlight release today/tomorrow to see how it's all working, and continue on #76 in the meanwhile for the App Store release of 1.0.1 while that's in public beta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Works great!
Closes #104 for the iOS app; must also be implemented for the Mac app, but that's a fair bit more work, so we'll punt on this for now.
This PR also adds some little quality-of-life fixes, like the Return key switching focus from the title field to the body field (but not vice versa), and a multi-line, auto-expanding title field.