Skip to content

Conversation

AngeloStavrow
Copy link
Collaborator

Closes #104 for the iOS app; must also be implemented for the Mac app, but that's a fair bit more work, so we'll punt on this for now.

This PR also adds some little quality-of-life fixes, like the Return key switching focus from the title field to the body field (but not vice versa), and a multi-line, auto-expanding title field.

@AngeloStavrow AngeloStavrow added this to the 1.0.1 milestone Oct 28, 2020
@AngeloStavrow AngeloStavrow requested a review from thebaer October 28, 2020 20:54
@AngeloStavrow AngeloStavrow self-assigned this Oct 28, 2020
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 The Title field focus on load works perfectly!

One change I think we should implement, now that the title field auto-expands: add lineSpacing to that text field.

Otherwise, in my testing, I noticed that pressing Return to move from Title to Body only works once. If that's a quick fix, I think we should fix it here. Otherwise it's not critical, so we can fix it another time.

@AngeloStavrow
Copy link
Collaborator Author

Very nice 👍 The Title field focus on load works perfectly!

🎉

One change I think we should implement, now that the title field auto-expands: add lineSpacing to that text field.

Should be pretty straightforward. 👍

Otherwise, in my testing, I noticed that pressing Return to move from Title to Body only works once. If that's a quick fix, I think we should fix it here. Otherwise it's not critical, so we can fix it another time.

Good catch, I managed to repro this. I think I understand what's happening here, so I'll spend a little time this afternoon working on this; if possible, I'd like to push out another TestFlight release today/tomorrow to see how it's all working, and continue on #76 in the meanwhile for the App Store release of 1.0.1 while that's in public beta.

@AngeloStavrow AngeloStavrow requested a review from thebaer November 2, 2020 20:07
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Auto-focus on Title field upon loading empty editor
2 participants