Skip to content

Override app delegate methods for window deminiaturization #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2021
Merged

Override app delegate methods for window deminiaturization #188

merged 1 commit into from
Aug 27, 2021

Conversation

AngeloStavrow
Copy link
Collaborator

@AngeloStavrow AngeloStavrow commented Aug 20, 2021 •
edited
Loading

This PR fixes #135.

There are a couple of "known issues" with this that isn't exactly like an AppKit's app behaviour:

  1. If there's a Finder window open, but behind some other app's window, it's brought to the foreground when WriteFreely for Mac is minimized.
  2. If WriteFreely for Mac is minimized, and option+tab is used to select it, it is de-miniaturized.

Otherwise, it works pretty well. Opened a Feedback with Apple (FB9541697) to address this workaround.

@AngeloStavrow AngeloStavrow added this to the 1.0 milestone Aug 20, 2021
@AngeloStavrow AngeloStavrow requested a review from thebaer August 20, 2021 19:06
@AngeloStavrow AngeloStavrow self-assigned this Aug 20, 2021
thebaer
thebaer approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after reading through!

@AngeloStavrow AngeloStavrow merged commit b9df0ab into main Aug 27, 2021
@AngeloStavrow AngeloStavrow deleted the restore-window-when-clicking-dock-icon branch August 27, 2021 18:05
@AngeloStavrow AngeloStavrow added the mac Anything specific to the Mac app label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebaer thebaer thebaer approved these changes

Assignees

@AngeloStavrow AngeloStavrow

Labels
mac Anything specific to the Mac app
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Clicking dock icon when minimized does not restore window
2 participants
@AngeloStavrow @thebaer