Skip to content

Add action extension for Safari #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 3, 2021
Merged

Add action extension for Safari #198

merged 7 commits into from
Dec 3, 2021

Conversation

AngeloStavrow
Copy link
Collaborator

@AngeloStavrow AngeloStavrow commented Nov 28, 2021 •
edited
Loading

This PR closes #164.

It includes:

  • a JavaScript file for getting the title, URL, and selected text (if any) in the active web page
  • an Action Extension whose main view has been written in SwiftUI and is presented in a traditional UIKit view controller via a UIHostingView
  • a couple of modifications to WFDefaults to add some more user defaults for sharing with between the iOS app and the extension
  • some custom assets for the extension's "app icon" as shown in the share sheet

@AngeloStavrow AngeloStavrow added the ios Anything specific to the iPhone/iPad app label Nov 28, 2021
@AngeloStavrow AngeloStavrow self-assigned this Nov 28, 2021
@AngeloStavrow AngeloStavrow changed the base branch from main to move-defaults-to-app-group November 28, 2021 13:09
@AngeloStavrow AngeloStavrow changed the base branch from move-defaults-to-app-group to main November 28, 2021 13:39
thebaer
thebaer approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after reading through!

@AngeloStavrow AngeloStavrow merged commit 43e4756 into main Dec 3, 2021
@AngeloStavrow AngeloStavrow deleted the add-extension branch December 3, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebaer thebaer thebaer approved these changes

Assignees

@AngeloStavrow AngeloStavrow

Labels
ios Anything specific to the iPhone/iPad app
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Action extension for sharing text from other apps to WriteFreely
2 participants
@AngeloStavrow @thebaer