Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use recommended solver #12

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

hubcity
Copy link
Contributor

@hubcity hubcity commented Jan 20, 2024

@wscott
Copy link
Owner

wscott commented Jan 21, 2024

Interesting. For me, this change names the output "cleaner" and less random looking and generates the same level of living expenses, but the final amount paid for taxes is higher:

-total spending: 15876539
-total tax: 1984385 (12.5%)
+total spending: 15829379
+total tax: 2131504 (13.5%)

I am pretty sure this is why the change to avoid Roth conversions didn't work when I tried it in my tree.

@wscott
Copy link
Owner

wscott commented Jan 21, 2024

I thought about this and realized that we don't tell it to minimize taxes and as long as the spending is maximized both solutions are good.

I muse about how to fix this in #17.

So I am going to accept this one as is.

@wscott wscott merged commit 0bf14bd into wscott:master Jan 21, 2024
@hubcity hubcity deleted the linprog-solver branch January 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants