-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: edit mcdict in a separate page #67
Conversation
It seems you didn't commit |
Could you please add an "Edit Dictionary" button, which is just a link to It is recommended to merge the |
I found the Line 112 in a91d2a8
Should I fix this to commit |
For clarification, which of the followings do you mean?
|
Sorry, I don't get the points of this. Can you tell me what actions I should take...? |
Oh, it seems this was introduced to ignore the top-level |
Either is fine. Maybe the second is better since the current |
Please just execute |
Maybe, should we add something like "Back to index page" button to /edit_mcdict page...? |
This would be the fix for #58 .
Added features:
http://localhost:4100/edit_mcdict
http://localhost:4100/
andhttp://localhost:4100/edit_mcdict
are open at the same time and the mcdict is modified by either of them, then the other page is automatically reloaded to ensure the mcdict is the latest onehttp://localhost:4100/mcdict.json
, where the json is a tuple[${version}, ${mcdict}]
File structures:
To run the edit mcdict page separately, a ts script (
client/edit_mcdict.ts
) and an html template (server/templates/edit_mcdict.html
) are added.Currently,
edit_mcdict.ts
andindex.ts
does not share any functions; they actually do use some common codes but the codes are copy-and-pasted fromindex.ts
toedit_mcdict.ts
, where the same functions are defined locally (usingexport {}
).These two ts files are compiled at the same via
webpack.config.js
.