Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi components checking #216

Merged
merged 3 commits into from
Nov 23, 2023
Merged

OSGi components checking #216

merged 3 commits into from
Nov 23, 2023

Conversation

krystian-panek-vmltech
Copy link
Contributor

@krystian-panek-vmltech krystian-panek-vmltech commented Nov 23, 2023 •
edited
Loading

considering adding to project-specific aem.yml

    component_stable:
      pids_ignored:
        - "com.mysite.aem.oldone.StillNeededButFailingTemporarily"
        - "com.mysite.aem.oldone.AnotherStillNeededButFailingTemporarily"
      pids_failed_activation: ["*"]
      pids_unsatisfied_reference: ["com.mysite.*"]

then AEMC will detect potential problems with OSGi service right after deploying them to the instance.

WDYT? :)

@krystian-panek-vmltech krystian-panek-vmltech added the improvement Improvement to an existing feature label Nov 23, 2023
@jan-kowalczyk-wttech
Copy link
Contributor

jan-kowalczyk-wttech commented Nov 23, 2023 •
edited
Loading

I would add additional flag, that will disable this check.
This can be useful to decrease deployment time, when you are sure, that all packages are valid.

@krystian-panek-vmltech krystian-panek-vmltech mentioned this pull request Nov 23, 2023
Open
@krystian-panek-vmltech
Copy link
Contributor Author

done, specific checks could be now skipped; thanks @jan-kowalczyk-wttech for the review

@krystian-panek-vmltech krystian-panek-vmltech merged commit d6526c9 into main Nov 23, 2023
1 check passed
@krystian-panek-vmltech krystian-panek-vmltech deleted the osgi-components-checking branch November 23, 2023 09:27
@krystian-panek-vmltech krystian-panek-vmltech mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-kowalczyk-wttech jan-kowalczyk-wttech jan-kowalczyk-wttech left review comments

@tomasz-sobczyk-wttech tomasz-sobczyk-wttech Awaiting requested review from tomasz-sobczyk-wttech

@maciej-majchrzak-wttech maciej-majchrzak-wttech Awaiting requested review from maciej-majchrzak-wttech

@jaroslaw-pietraszek-vml jaroslaw-pietraszek-vml Awaiting requested review from jaroslaw-pietraszek-vml

Assignees
No one assigned
Labels
improvement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystian-panek-vmltech @jan-kowalczyk-wttech