Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean configuration legacy for useProxy configuration #56

Closed
wiiitek opened this issue Feb 5, 2017 · 1 comment
Closed

clean configuration legacy for useProxy configuration #56

wiiitek opened this issue Feb 5, 2017 · 1 comment

Comments

@wiiitek
Copy link
Contributor

wiiitek commented Feb 5, 2017

Currently there is a possibility to configure web proxy with "true" value.
This makes the code unclear: see also the discussion for pull request at:

For resolution I like the second approach more:

there will be only named type of a proxy (remove true as a possible value) after deprecating it first for e.g. 2 minor versions

(Alternative solution is to have the configuration value "default" be interpreted as "rest" proxy.)

Currently all suites using web proxy have it configured to "rest" as otherwise it doesn't work.

@malaskowski
Copy link
Contributor

As currently true does not work, i think we can get rid of it with no deprecated period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants