Get rid of empty init functions #701
Conversation
Doesn't allocate handles
| initFuncs.forEach(func -> { | ||
| ImVar globalBridge = null; | ||
| for (ImVar global : prog.getGlobals()) { | ||
| if (global.getName().equals("ref_function_" + func.getName())) { |
There was a problem hiding this comment.
I don't like using the name here. Names should not matter in the intermediate language.
| List<ImFunction> initFuncs = prog.getFunctions().stream().filter(func -> func.getName().startsWith | ||
| ("init_") && func.getBody().size() == 1).collect(Collectors.toList()); | ||
|
|
||
| initFuncs.forEach(func -> { |
There was a problem hiding this comment.
please use normal for-loops -- better performance, better stack traces, better debugging, easier to read
| if (body.get(finalI - 1) instanceof ImFunctionCall) { | ||
| body.get(finalI - 1).replaceBy(JassIm.ImNull()); | ||
| } | ||
| body.get(finalI + 1).replaceBy(JassIm.ImNull()); |
There was a problem hiding this comment.
What is the -1 and +1 doing here? Looks like you are assuming that there are always certain other statements around a call to TriggerAddCondition but that does not seem very reliable to me.
There was a problem hiding this comment.
The init calls are always generated the same way. Unless someone names a function "ref_function_" or so (which is the name issue above) then it seems reliable to me.
No idea where to start with that tbh. The old ticket & solution have been around for a while, this is one without inlining again. |
|
@peq ? |
Removes empty package init functions, see #511