Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow equality checks between agent types #932

Merged
merged 3 commits into from Feb 1, 2020
Merged

Allow equality checks between agent types #932

merged 3 commits into from Feb 1, 2020

Conversation

Frotty
Copy link
Member

@Frotty Frotty commented Jan 31, 2020

Jass allows this 馃し鈥嶁檪

@Frotty Frotty requested a review from peq January 31, 2020 18:16
@coveralls
Copy link

coveralls commented Jan 31, 2020 •
edited

Coverage Status

Coverage increased (+0.2%) to 59.837% when pulling 69d710d on agent-type-comparisons into e948e39 on master.

peq
peq requested changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@peq peq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can allow it in Jass code, but I would keep the more precise rules for Wurst. Comparing a sound and a rect is definitely a bug that the compiler should catch.

@Frotty
Copy link
Member Author

Frotty commented Jan 31, 2020

Done. There are now 2 separate tests.

@Frotty Frotty merged commit d79f738 into master Feb 1, 2020
@Frotty Frotty deleted the agent-type-comparisons branch February 1, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peq peq peq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frotty @coveralls @peq