Skip to content

Reduce log spam #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2020
Merged

Reduce log spam #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/ModelManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ private WurstCompilerJassImpl getCompiler(WurstGui gui) {
}

private void updateModel(CompilationUnit cu, WurstGui gui) {
WLogger.info("update model with " + cu.getCuInfo().getFile());
WLogger.trace("update model with " + cu.getCuInfo().getFile());
parseErrors.put(wFile(cu), new ArrayList<>(gui.getErrorsAndWarnings()));

WurstModel model2 = model;
Expand Down Expand Up @@ -518,23 +518,26 @@ private CompilationUnit replaceCompilationUnit(WFile filename, String contents,
}
if (fileHashcodes.containsKey(filename)) {
int oldHash = fileHashcodes.get(filename);
WLogger.info("oldHash = " + oldHash + " == " + contents.hashCode());
if (oldHash == contents.hashCode()) {
// no change
WLogger.info("CU " + filename + " was unchanged.");
WLogger.trace("CU " + filename + " was unchanged.");
return getCompilationUnit(filename);
} else {
WLogger.info("CU changed. oldHash = " + oldHash + " == " + contents.hashCode());
}
}

WLogger.info("replace CU " + filename);
WLogger.trace("replace CU " + filename);
WurstGui gui = new WurstGuiLogger();
WurstCompilerJassImpl c = getCompiler(gui);
CompilationUnit cu = c.parse(filename.toString(), new StringReader(contents));
cu.getCuInfo().setFile(filename.toString());
updateModel(cu, gui);
fileHashcodes.put(filename, contents.hashCode());
if (reportErrors) {
WLogger.info("found " + gui.getErrorCount() + " errors in file " + filename);
if (gui.getErrorCount() > 0) {
WLogger.info("found " + gui.getErrorCount() + " errors in file " + filename);
}
reportErrors("sync cu " + filename, filename, gui.getErrorsAndWarnings());
}
return cu;
Expand Down
4 changes: 2 additions & 2 deletions ...eeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/WurstWorkspaceService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ public CompletableFuture<List<? extends SymbolInformation>> symbol(WorkspaceSymb

@Override
public void didChangeConfiguration(DidChangeConfigurationParams params) {
WLogger.info("didChangeConfiguration");
WLogger.trace("didChangeConfiguration");

}

@Override
public void didChangeWatchedFiles(DidChangeWatchedFilesParams params) {
WLogger.info("didChangeWatchedFiles");
WLogger.trace("didChangeWatchedFiles");
server.worker().handleFileChanged(params);
}

Expand Down