New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TargetsAllowed to prevent typos #54

Merged
merged 3 commits into from Mar 12, 2018

Conversation

Projects
None yet
2 participants
@karlek
Copy link
Contributor

karlek commented Mar 8, 2018

Would also be really helpful if we could comment each value so it would be clearer what the differences is between allies and friends for example.

Any feedback on the choice of suffixing the values with _t to avoid the namespace collision?

karlek added some commits Mar 8, 2018

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Mar 10, 2018

Perhaps public import in UnitObjEditing?
I think, ideally, such string lists should never be parameters in object calls, and instead directly provide an abstraction that prevents typos.
Like this, you still have to create the list properly, and there is much room for error.
Of course I will still merge for it's usefulness.

@karlek

This comment has been minimized.

Copy link
Contributor

karlek commented Mar 10, 2018

I agree with public import in UnitObjEditing (fixed in latest commit) and also that passing a list as argument is sub-optimal. This will could be fixed if varargs would be added to wurst, as you've discussed at length in tickets and IRC :)

@Frotty

This comment has been minimized.

Copy link
Member

Frotty commented Mar 12, 2018

sweet 🍬
Can upgrade this in the future then.

@Frotty Frotty merged commit 1606a0f into wurstscript:master Mar 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment