Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates Getting Started with Programmatic UIKit #37

Merged
merged 8 commits into from Jun 11, 2021

Conversation

wiemerm
Copy link
Contributor

@wiemerm wiemerm commented Jun 10, 2021

Linked Issue:

Checklist:


If Applicable:

  • Did you test when the first item is skipped?
  • Did you test when the last item is skipped?
  • Did you test when middle items are skipped?
  • Did you test when incorrect data is passed forward?
  • Did you test proceeding backwards?

If Public API Has Changed:

  • Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
  • Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
  • If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

@cla-bot cla-bot bot added the cla-signed label Jun 10, 2021
@wiemerm wiemerm added this to In progress (3) in SwiftCurrent Kanban Jun 10, 2021
@wiemerm
Copy link
Contributor Author

wiemerm commented Jun 10, 2021

EOD: We created a sample project to build out what Getting Started with Programmatic views and added an initial version of what this Getting Started would look like using the Getting Started with Storyboards as a reference.

We discussed whether to break out the view code into separate views or keep them within the UIViewControllers. We chose to put them in the view controllers in order to cut down on boilerplate code and avoid prescribing a particular way of setting up views.

@wiemerm wiemerm added the documentation Improvements or additions to documentation label Jun 10, 2021
@wiemerm wiemerm added this to the Great Onboarding Experience milestone Jun 10, 2021
Megan Wiemer added 2 commits June 10, 2021 20:48
@Richard-Gist
Copy link
Collaborator

We discussed whether to break out the view code into separate views or keep them within the UIViewControllers. We chose to put them in the view controllers in order to cut down on boilerplate code and avoid prescribing a particular way of setting up views.

I've been out of the programmatic views for awhile. If this is what we would do for our projects, we're good. If we would not do it for our projects, we should have a call out that we are doing it for the sake of the guide.

…Kit to the wiki Home as an additional option - MW
@wiemerm wiemerm marked this pull request as ready for review June 11, 2021 16:10
Copy link
Collaborator

@Richard-Gist Richard-Gist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not done reviewing but hit enough issues to share my comments.

wiki/Home.md Outdated Show resolved Hide resolved
wiki/Home.md Outdated Show resolved Hide resolved
wiki/Getting-Started-UIKit.md Outdated Show resolved Hide resolved
wiki/Getting-Started-UIKit.md Outdated Show resolved Hide resolved
Megan Wiemer added 4 commits June 11, 2021 13:40
@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Richard-Gist Richard-Gist merged commit 8fd91a4 into main Jun 11, 2021
@Richard-Gist Richard-Gist deleted the getting-started-updates branch June 11, 2021 19:09
@Richard-Gist Richard-Gist moved this from In progress (3) to Review (2) in SwiftCurrent Kanban Jun 11, 2021
@Richard-Gist Richard-Gist moved this from Review (2) to Ready for Demo in SwiftCurrent Kanban Jun 11, 2021
@Richard-Gist Richard-Gist moved this from Ready for Demo to Done in SwiftCurrent Kanban Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants