Merge pull request #176 from motemen/iss173

Ignore files which seems to system hidden file in walking

list_test.go

@@ -174,10 +174,8 @@ func TestDoList_unique(t *testing.T) {
 
 func TestDoList_unknownRoot(t *testing.T) {
 	defer func(orig []string) { _localRepositoryRoots = orig }(_localRepositoryRoots)
-	defer func(orig string) { os.Setenv("GHQ_ROOT", orig) }(os.Getenv("GHQ_ROOT"))
-
+	defer tmpEnv("GHQ_ROOT", "/path/to/unknown-ghq")()
 	_localRepositoryRoots = nil
-	os.Setenv("GHQ_ROOT", "/path/to/unknown-ghq")
 
 	err := newApp().Run([]string{"ghq", "list"})
 	if err != nil {
@@ -187,19 +185,37 @@ func TestDoList_unknownRoot(t *testing.T) {
 
 func TestDoList_notPermittedRoot(t *testing.T) {
 	defer func(orig []string) { _localRepositoryRoots = orig }(_localRepositoryRoots)
-	defer func(orig string) { os.Setenv("GHQ_ROOT", orig) }(os.Getenv("GHQ_ROOT"))
 	tmpdir := newTempDir(t)
 	defer func(dir string) {
 		os.Chmod(dir, 0755)
 		os.RemoveAll(dir)
 	}(tmpdir)
+	defer tmpEnv("GHQ_ROOT", tmpdir)()
 
 	_localRepositoryRoots = nil
-	os.Setenv("GHQ_ROOT", tmpdir)
 	os.Chmod(tmpdir, 0000)
 
 	err := newApp().Run([]string{"ghq", "list"})
 	if !os.IsPermission(xerrors.Unwrap(err)) {
 		t.Errorf("error should be ErrNotExist, but: %s", err)
 	}
 }
+
+func TestDoList_withSystemHiddenDir(t *testing.T) {
+	defer func(orig []string) { _localRepositoryRoots = orig }(_localRepositoryRoots)
+	tmpdir := newTempDir(t)
+	systemHidden := filepath.Join(tmpdir, ".system")
+	os.MkdirAll(systemHidden, 0000)
+	defer func(dir string) {
+		os.Chmod(systemHidden, 0755)
+		os.RemoveAll(dir)
+	}(tmpdir)
+	defer tmpEnv("GHQ_ROOT", tmpdir)()
+
+	_localRepositoryRoots = nil
+
+	err := newApp().Run([]string{"ghq", "list"})
+	if err != nil {
+		t.Errorf("error should be nil, but: %s", err)
+	}
+}

local_repository.go

@@ -209,6 +209,9 @@ func walkLocalRepositories(callback func(*LocalRepository)) error {
 				if err == nil || os.IsNotExist(err) {
 					return nil
 				}
+				if os.IsPermission(err) && filepath.Base(fpath)[0] == '.' {
+					return nil
+				}
 				return err
 			}
 			if fi.Mode()&os.ModeSymlink == os.ModeSymlink {