WebAssembly: fix execution context for methods that require Window interface #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our playground uses special proxy object to inject/customize global scope of Go's WebAssembly bridge (
wasm_exec.js
) by wrappingglobalThis
with proxy object.Some
window
calls, likewindow.alert
require that execution context object should bewindow
.When proxy object passed instead, occurs an error:
Prototype swap by using
setPrototypeOf
also doesn't work.This PR adds method owner check during method call as a workaround, which replaces proxy object with original
window
during call on anywindow
member method (likealert()
).