This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Update to v25.1.0 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way if the names change or we lose documentation from them in the future, it won't cause the whole build to explode
In the java api we had some overloads that accepted strings where CharSequence was used in other overloads. We automatically do this, so the string versions were conflicting with what we generate. We can just keep the CharSequence versions since we generate the wrapper methods overloads to accept strings anyway.
DroidDocs parsing is broken on docs-24+, so moving back to 23 to make things compile more cleanly. Will be investigating using different doc sources
Also adding generated.targets import for XBD to use
The new generated targets file will take over the old name. The old task goes into its own targets file with its own new name.
Use AAR_INFOS instead
This should fix #19
This will support partial zip downloads in the latest Xamarin.Build.Download
Previously the XamarinBuildDownloadPartialZip item was getting added if the .aar wasn’t in the Android SDK location. If the .aar exists already in the download cache, we were still running the task to look for this item. Now the task would figure out quickly the item didn’t need downloading and was already cached, but with this changed condition we don’t even have to go that far to figure out it’s not needed.
SupportConsts was only used to populate the attributes for downloading at build time. This is unnecessary with Xamarin.Build.Download
Was false positively matching v17-leanback to prefrence-v17-leanback causing the wrong .aar to be downloaded.
We can only have one .targets file in a nupkg that gets auto-imported into the project (it must be named nuget-package-id.targets), and since some of our packages already were using this file, we need to merge the generated targets for Xamarin.Build.Download with these files. This means the custom build tasks must be built before the nuget-setup task runs. This changes the build script to build the existing custom tasks, copy their .targets files, and then detect them when generated the .targets files for Xamarin.Build.Download, and merge them together.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.