This repository was archived by the owner on May 15, 2024. It is now read-only.
Fixes #1066 Need to cache locationmanager or dialog dissapears #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
Jan 29, 2020
|
|
||
| internal static Task<PermissionStatus> RequestLocationAsync(bool whenInUse, Action<CLLocationManager> invokeRequest) | ||
| { | ||
| var locationManager = new CLLocationManager(); |
There was a problem hiding this comment.
What happens if we come back in here without waiting for the flow to complete? We might leak...
|
The dialog box does not appear at all in iOS when calling Meanwhile the other permissions like Mic and camera works just fine with the permission dialog. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Must cache location manager: https://stackoverflow.com/questions/7888896/current-location-permission-dialog-disappears-too-quickly/8170382
Clean it up when doen.
Bugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
None
Behavioral Changes
Else dialog disappears :(
PR Checklist