This repository was archived by the owner on May 15, 2024. It is now read-only.
Added macOS FilePicker implementation #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Redth @mattleibow This PR is ready; I tested picking files on MacOS Catalina 10.15.3. By the way, I noticed that the Sample app doesn't show any of the icons in the feature list. |
Redth
approved these changes
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds the implementation of file picking on macOS, both single and multiple file picking. It compiles but couldn't test it yet.
Note that this change requires the changes from PR #653 that adds macOS as backend. I add the PR as draft pull request.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
PR Checklist