This repository was archived by the owner on May 15, 2024. It is now read-only.
iOS Keep things in scope #1380
Merged
iOS Keep things in scope #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set null once we have the callback
Use a delegate to dispose of the controller instance once it's no longer needed.
5 tasks
|
Had to update the iOS simulator version because the bots are updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There are a couple of issues related to what I believe could be do to something going out of scope and being GC'd before the native action is complete.
This PR just keeps some instances around (and attempts to clean them up when finished).
Bugs Fixed