Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Make sure we don't keep calling the same method recursively #39

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Make sure we don't keep calling the same method recursively #39

merged 1 commit into from
Feb 27, 2018

Conversation

mattleibow
Copy link
Contributor

  • use the generic
  • Set does not return a value
  • make SharedName a readonly value

@mattleibow
Make sure we don't keep calling the same method recursively
f064e81 
 - use the generic
 - Set does not return a value
 - make SharedName a readonly value
@mattleibow mattleibow added the bug Something isn't working label Feb 27, 2018
@mattleibow mattleibow added this to the Preview-1 milestone Feb 27, 2018
@mattleibow mattleibow merged commit d26f918 into master Feb 27, 2018
@mattleibow mattleibow deleted the preferences-fix branch February 27, 2018 22:40
This was referenced Mar 11, 2019
Merged
Merged
Merged
Closed
Merged
Merged
@ghost ghost mentioned this pull request Mar 19, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@jamesmontemagno jamesmontemagno Awaiting requested review from jamesmontemagno

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0-preview
Development

Successfully merging this pull request may close these issues.
2 participants
@mattleibow @Redth