GH-672: Update SMS recipient #674

jamesmontemagno · 2019-01-02T19:28:27Z

Description of Change

Adds a constructor for a single recipient.

Bugs Fixed

Related to issue Add back SmsMessage with single recipient. #672

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

SmsMessage.ctr(string, string);

Behavioral Changes

None

PR Checklist

Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of master at time of PR
Changes adhere to coding standard
Updated documentation (see walkthrough)

VSC-Service-Account · 2019-01-02T19:28:32Z

OPS Build status updates of commit da6920d:

🕙 Preparing: average preparing time is 54 sec(s)

VSC-Service-Account · 2019-01-02T19:29:25Z

OPS Build status updates of commit da6920d:

🕙 Incremental building: average incremental building time is 24 sec(s)

VSC-Service-Account · 2019-01-02T19:29:55Z

OPS Build status updates of commit da6920d:

✅ Validation status: passed

File	Status	Preview URL	Details
Xamarin.Essentials/GlobalSuppressions.shared.cs	✅Succeeded
Xamarin.Essentials/Sms/Sms.shared.cs	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml	✅Succeeded
docs/en/Xamarin.Essentials/SmsMessage.xml	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Mrnikbobjeff

Just a little thing :)

Xamarin.Essentials/Sms/Sms.shared.cs

mattleibow

Good point. I would even say go further and forget about the chaining of constructors:

public SmsMessage() {
}
public SmsMessage(string body, string recipient) {
    Body = body;
    if (!string.IsNullOrWhiteSpace(recipient))
        Recipients.Add(recipient);
}
public SmsMessage(string body, IEnumerable<string> recipients) {
    Body = body;
    if (recipients != null) {
        Recipients = recipients.Where(x => !string.IsNullOrWhiteSpace(x))?.ToList();
    }
}
// . . .
public List<string> Recipients { get; set; } = new List<string>();

We don't have to care about the initial size of the list as the default size is 4 (if corefx is anything to go by).

Mrnikbobjeff · 2019-01-07T12:58:52Z

Well I believe if I were to add multiple recipients you would use the constructor accepting an IEnumerable. If you use the constructor with a single recipient I would rather explicitly set the Capacity of the List as this will probably be enough for the common use case of this constructor.

VSC-Service-Account · 2019-01-07T21:50:36Z

OPS Build status updates of commit f88f181:

🕙 Preparing: average preparing time is 54 sec(s)

VSC-Service-Account · 2019-01-07T21:51:34Z

OPS Build status updates of commit f88f181:

🕙 Incremental building: average incremental building time is 24 sec(s)

VSC-Service-Account · 2019-01-07T21:52:01Z

OPS Build status updates of commit f88f181:

✅ Validation status: passed

File	Status	Preview URL	Details
Xamarin.Essentials/GlobalSuppressions.shared.cs	✅Succeeded
Xamarin.Essentials/Sms/Sms.shared.cs	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml	✅Succeeded
docs/en/Xamarin.Essentials/SmsMessage.xml	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

jamesmontemagno · 2019-01-07T21:53:19Z

Updated! @mattleibow

updated!

mattleibow · 2019-01-08T01:02:06Z

docs/en/FrameworksIndex/xamarin-essentials-android.xml

@@ -10,22 +10,18 @@
      <Member Id="P:Xamarin.Essentials.Accelerometer.IsMonitoring" />
    </Type>
    <Type Name="Xamarin.Essentials.AccelerometerChangedEventArgs" Id="T:Xamarin.Essentials.AccelerometerChangedEventArgs">
-      <Member Id="M:Xamarin.Essentials.AccelerometerChangedEventArgs.#ctor(Xamarin.Essentials.AccelerometerData)" />


I think something went wrong with this file... There are too many changes.

Good catch... it is like something reverted... <3

VSC-Service-Account · 2019-01-08T18:50:57Z

OPS Build status updates of commit 854a792:

🕙 Preparing: average preparing time is 54 sec(s)

VSC-Service-Account · 2019-01-08T18:52:00Z

OPS Build status updates of commit 854a792:

🕙 Incremental building: average incremental building time is 24 sec(s)

VSC-Service-Account · 2019-01-08T18:52:22Z

OPS Build status updates of commit 854a792:

✅ Validation status: passed

File	Status	Preview URL	Details
Xamarin.Essentials/GlobalSuppressions.shared.cs	✅Succeeded
Xamarin.Essentials/Sms/Sms.shared.cs	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml	✅Succeeded
docs/en/Xamarin.Essentials/SmsMessage.xml	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

jamesmontemagno · 2019-01-08T18:55:29Z

@mattleibow should be good now!

Updated code

VSC-Service-Account · 2019-01-08T19:48:32Z

OPS Build status updates of commit 1cb2515:

🕙 Preparing: average preparing time is 54 sec(s)

mattleibow

MERGE!

VSC-Service-Account · 2019-01-08T19:49:30Z

OPS Build status updates of commit 1cb2515:

🕙 Incremental building: average incremental building time is 23 sec(s)

VSC-Service-Account · 2019-01-08T19:49:54Z

OPS Build status updates of commit 1cb2515:

✅ Validation status: passed

File	Status	Preview URL	Details
Xamarin.Essentials/GlobalSuppressions.shared.cs	✅Succeeded
Xamarin.Essentials/Sms/Sms.shared.cs	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml	✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml	✅Succeeded
docs/en/Xamarin.Essentials/SmsMessage.xml	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Redth

* GH-491: Fix version parsing (#492) * Fix version parsing * Util tests * GH-373: Permissions Must Be Invoked on MainThread else Throw Exception (#487) * Throw permission exception if not on main thread when we need to request. * Add tests for not main thread permissions * Ensure we use culure invarient on tostring (#483) * Integrate sourcelink - https://github.com/dotnet/sourcelink (#260) * Integrate sourcelink https://github.com/dotnet/sourcelink * Add /p:ContinuousIntegrationBuild=true to build.ps1 * Update Xamarin.Essentials.csproj * Update build.ps1 * Update to latest source link * Only add sourcelink in release config * Cleanup build for mac * Add properties to turn off CI on device tests. * Use strings * Use list * missed one * Only add on release and windows :) * GH-476: Put in checks to see if location services are enabled. (#488) * Put in checks to see if location services are enabled. * iOS check to see if location services are enabled. * GH-383: Multiple sms recipients (#484) * GH-383: Multiple sms recipients (#415) * Docs * Added multiple Recipient capabilities * Updated docs * PR requests * SMS docs and comments * Fixed potential nullreferenceexception * Updated SMS message as requested * Updated Samples for SMS * Updated sms docs via copying files to right directory. * Updated label in sample * Fixed comment slash * Code cleanup. * Update sample for iOS support * Null checks for @Redth * Removed duplicated/unnecessary argument validation. (#509) * Removed duplicated/unnecessary argument validation. The argument validation is being done under `SecureStorage.shared.cs`. * Re-added parameter validation to iOS specific call. As requested (correctly) in the review, I re-added the parameter validation for the specific iOS call to `SetAsync `. * Cleaned online editor whitespaces. * Handle the case when a key does not exist in the iOS Info.plist. Fixes #523 (#525) * GH-464 Dispose of any SecRecord inside of the keychain (#499) * Dispose of any SecRecord inside of the keychain * Reduced the double indent of the nested usings * Use specified version of ECMA2Yaml to work around (#532) Latest version of ECMA2Yaml has some issue with this repository. Need investigate more, use 1.0.417 version as workaround. * Add ToString overrides on a bunch of types to improve debugging information (#531) * Add ToString overrides on a bunch of types to improve debugging information * Remove trailing spaces * use nameof for all tostring and also update placemark (location is in another pr) (#539) * Change name to Timestamp. (#538) * Change name to Timestamp. * Cleanup extensions * Add progaurd file for reference (#530) * Add progaurd file for reference * minimize progaurd * Fix #534 by setting default language to english before creating keyge… (#536) * Fix #534 by setting default language to english before creating keygenerator. * Fix build! * Add sample of backup rools, and handl AEADBadTagException (#540) * Add sample of backup rools, and handl AEADBadTagException * Typos * Update iOS Simulator version in device tests * Regenerate the docs (#541) * Update the build bits for the new things * Re-generate the docs * Markdown and edit fixes. (#528) * Catch FeatureNotSupportedException when navigating back (#558) * Update Xamarin.Essentials.csproj (#552) * iOS don't throw exception when removing key that doesn't exist (#562) * Integrate App Center SDK into Sample App (#557) * Update NuGets! * Added App Center Integration. Added SDKs, build scripts for app Ids, and enabled distribute all sample apps. * cat test * Fix android! * Remove cat * Add file for common constants! Fix sh scripts. * Update readme! * fix null reference exceptions for missing Locale in SpeakSettings (#588) * [Share] Renamed DataTransfer to Share. Fixes #577 (#586) * Added some guiding principles for new feature work (#585) * Added some guiding principles for new feature work * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * More contribution guide updates * Update CONTRIBUTING.md Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com> * Update README.md (#603) * Increase Device Test timeout * GH-629 Fixed launcher sample project (#630) * Small main thread optimization * redo commit * Udated docs * Revert "Udated docs" This reverts commit 4c721d3. * Added exception handling * Docs fixed * Remove whitespace * API Fixes (#590) * Rename AppInfo.OpenSettings -> ShowSettingsUI Fixes #567 * Missed one docs rename * Added back a missing using. * Fixed up Clipboard API! Updated everything SetTextAsync. Update xunit test runners * Updates Connectivity APIs from the review! got rid of Other made it unknown, removed WiMAX and updated Profiles to ConnectionProfiles * Change MapKey to Platform.MapServiceToken only for UWP * Dropping the version of the device runner until we can figure out what is broken on UWP (#596) * Update docs/en/FrameworksIndex/xamarin-essentials-uwp.xml Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com> * Fix spacing * Updated DOCS! * Added Default and set it to Medium * [Platform] Remove the Platform for .net standard since it does nothing (#592) - closes #579 * GH-583: [api-fix] Power / Battery (#591) * Move the `Power` members into `Battery` Closes #583 * [Battery] If the charge can be determined, return 1.0 - if the device is on, then it must have some charge - chances are, the issue is that there is no battery at all (on power) - closes #583 * Merged the PR * GH-568: [api-fix] Browser (#589) * OpenAsync returns Task<bool> Also on iOS we can take advantage of some async methods like PresentViewControllerAsync now. * Update API docs * Update Browser.shared.cs * re-gen docs * Generated docs * Revert this to avoid conflicts * Add in DeviceIdiom and DevicePlatform * Updated the docs and added a .gitattributes to control the line endings * Renamed SpeakSettings to SpeechOptions. Closes #580 * Add docs about HTML emails not supported on UWP. Closes #578 * [Map] Fixed the type names and enum values. Closes #576 * Refactor display info and keep screen on. * Add device display. * Change to BatteryInfoChanged and BatteryInfoChangedEventArgs * Revert back battery intent * If we can't unwrap the key, then tear down everything and start over again. * Change back to "DisplayInfoChangedEventArgs" * Update Battery.android.cs * change to valid key * Update Battery.android.cs * Add docs * Rename file correctly for docs! * Cleanup docs * Catch only specific exceptions. some code cleanup * Updated the sensors to adhere to guidelines. #582 - enum names - compas low pass filter is now a param - updated docs - public constructors on data and events - stating an already started sensor will throw - sensor use the same units on all platforms Added a unit conversion API. #575 * Catch invalid key exception. * If there is no main window, then there is no UI thread. Closes 510 * Fixes #612 We shouldn't have a need for telephony as we don't check it on others and restricts VOIP apps. * Integrate html option into sample for email. (#623) * Add Unknown to DeviceType. Update .net standard to return unknown for platform/idiom/type (#627) * Update nugetreadme.txt (#625) * Make sure UWP DeviceTest deps are installed * Fixed up missed documentation updates * Remove some unintentional whitespace * GH-621 Fixes Main thread checks for permissions. (#640) * Swap version values on iOS This fixes #639 We were using the wrong version key/values from Info.plist for the respective AppInfo properties. * Ensure we only check is main thread when prompting * Revert "Swap version values on iOS" This reverts commit c61ef22. We actually have this correct. * Update nugetreadme.txt * Return distnct profiles. Added test as well. (#650) * Update README.md * Update README.md * GH-656: Connectivity Updates on Android for Not Available (#657) * Always check IsAvailable This may fix #656 on select phones where wifi is returned even though it isn't available. Still need to investigate profiles * removing whitespaces * [docs] Update global metadata for API docs (#659) * add global file metadata * update ms.topic * update topic to match .net docs * Update PULL_REQUEST_TEMPLATE.md * GH-668 Calculate Phone v Tablet on Android correctly (#670) Need to return known and calculate tablet vs phone as "Normal" is returned by all standard devices. * GH-672: Update SMS recipient (#674) * Add back constructor taking single recipient. * Update constructors * Clean up android xml * Update xamarin-essentials-android.xml

@Redth

* GH-491: Fix version parsing (#492) * Fix version parsing * Util tests * GH-373: Permissions Must Be Invoked on MainThread else Throw Exception (#487) * Throw permission exception if not on main thread when we need to request. * Add tests for not main thread permissions * Ensure we use culure invarient on tostring (#483) * Integrate sourcelink - https://github.com/dotnet/sourcelink (#260) * Integrate sourcelink https://github.com/dotnet/sourcelink * Add /p:ContinuousIntegrationBuild=true to build.ps1 * Update Xamarin.Essentials.csproj * Update build.ps1 * Update to latest source link * Only add sourcelink in release config * Cleanup build for mac * Add properties to turn off CI on device tests. * Use strings * Use list * missed one * Only add on release and windows :) * GH-476: Put in checks to see if location services are enabled. (#488) * Put in checks to see if location services are enabled. * iOS check to see if location services are enabled. * GH-383: Multiple sms recipients (#484) * GH-383: Multiple sms recipients (#415) * Docs * Added multiple Recipient capabilities * Updated docs * PR requests * SMS docs and comments * Fixed potential nullreferenceexception * Updated SMS message as requested * Updated Samples for SMS * Updated sms docs via copying files to right directory. * Updated label in sample * Fixed comment slash * Code cleanup. * Update sample for iOS support * Null checks for @Redth * Removed duplicated/unnecessary argument validation. (#509) * Removed duplicated/unnecessary argument validation. The argument validation is being done under `SecureStorage.shared.cs`. * Re-added parameter validation to iOS specific call. As requested (correctly) in the review, I re-added the parameter validation for the specific iOS call to `SetAsync `. * Cleaned online editor whitespaces. * Handle the case when a key does not exist in the iOS Info.plist. Fixes #523 (#525) * GH-464 Dispose of any SecRecord inside of the keychain (#499) * Dispose of any SecRecord inside of the keychain * Reduced the double indent of the nested usings * Use specified version of ECMA2Yaml to work around (#532) Latest version of ECMA2Yaml has some issue with this repository. Need investigate more, use 1.0.417 version as workaround. * Add ToString overrides on a bunch of types to improve debugging information (#531) * Add ToString overrides on a bunch of types to improve debugging information * Remove trailing spaces * use nameof for all tostring and also update placemark (location is in another pr) (#539) * Change name to Timestamp. (#538) * Change name to Timestamp. * Cleanup extensions * Add progaurd file for reference (#530) * Add progaurd file for reference * minimize progaurd * Fix #534 by setting default language to english before creating keyge… (#536) * Fix #534 by setting default language to english before creating keygenerator. * Fix build! * Add sample of backup rools, and handl AEADBadTagException (#540) * Add sample of backup rools, and handl AEADBadTagException * Typos * Update iOS Simulator version in device tests * Regenerate the docs (#541) * Update the build bits for the new things * Re-generate the docs * Markdown and edit fixes. (#528) * Catch FeatureNotSupportedException when navigating back (#558) * Update Xamarin.Essentials.csproj (#552) * iOS don't throw exception when removing key that doesn't exist (#562) * Integrate App Center SDK into Sample App (#557) * Update NuGets! * Added App Center Integration. Added SDKs, build scripts for app Ids, and enabled distribute all sample apps. * cat test * Fix android! * Remove cat * Add file for common constants! Fix sh scripts. * Update readme! * fix null reference exceptions for missing Locale in SpeakSettings (#588) * [Share] Renamed DataTransfer to Share. Fixes #577 (#586) * Added some guiding principles for new feature work (#585) * Added some guiding principles for new feature work * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: Redth <jondick@gmail.com> * More contribution guide updates * Update CONTRIBUTING.md Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com> * Update CONTRIBUTING.md Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com> * Update README.md (#603) * Increase Device Test timeout * GH-629 Fixed launcher sample project (#630) * Small main thread optimization * redo commit * Udated docs * Revert "Udated docs" This reverts commit 4c721d3. * Added exception handling * Docs fixed * Remove whitespace * API Fixes (#590) * Rename AppInfo.OpenSettings -> ShowSettingsUI Fixes #567 * Missed one docs rename * Added back a missing using. * Fixed up Clipboard API! Updated everything SetTextAsync. Update xunit test runners * Updates Connectivity APIs from the review! got rid of Other made it unknown, removed WiMAX and updated Profiles to ConnectionProfiles * Change MapKey to Platform.MapServiceToken only for UWP * Dropping the version of the device runner until we can figure out what is broken on UWP (#596) * Update docs/en/FrameworksIndex/xamarin-essentials-uwp.xml Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com> * Fix spacing * Updated DOCS! * Added Default and set it to Medium * [Platform] Remove the Platform for .net standard since it does nothing (#592) - closes #579 * GH-583: [api-fix] Power / Battery (#591) * Move the `Power` members into `Battery` Closes #583 * [Battery] If the charge can be determined, return 1.0 - if the device is on, then it must have some charge - chances are, the issue is that there is no battery at all (on power) - closes #583 * Merged the PR * GH-568: [api-fix] Browser (#589) * OpenAsync returns Task<bool> Also on iOS we can take advantage of some async methods like PresentViewControllerAsync now. * Update API docs * Update Browser.shared.cs * re-gen docs * Generated docs * Revert this to avoid conflicts * Add in DeviceIdiom and DevicePlatform * Updated the docs and added a .gitattributes to control the line endings * Renamed SpeakSettings to SpeechOptions. Closes #580 * Add docs about HTML emails not supported on UWP. Closes #578 * [Map] Fixed the type names and enum values. Closes #576 * Refactor display info and keep screen on. * Add device display. * Change to BatteryInfoChanged and BatteryInfoChangedEventArgs * Revert back battery intent * If we can't unwrap the key, then tear down everything and start over again. * Change back to "DisplayInfoChangedEventArgs" * Update Battery.android.cs * change to valid key * Update Battery.android.cs * Add docs * Rename file correctly for docs! * Cleanup docs * Catch only specific exceptions. some code cleanup * Updated the sensors to adhere to guidelines. #582 - enum names - compas low pass filter is now a param - updated docs - public constructors on data and events - stating an already started sensor will throw - sensor use the same units on all platforms Added a unit conversion API. #575 * Catch invalid key exception. * If there is no main window, then there is no UI thread. Closes 510 * Fixes #612 We shouldn't have a need for telephony as we don't check it on others and restricts VOIP apps. * Integrate html option into sample for email. (#623) * Add Unknown to DeviceType. Update .net standard to return unknown for platform/idiom/type (#627) * Update nugetreadme.txt (#625) * Make sure UWP DeviceTest deps are installed * Fixed up missed documentation updates * Remove some unintentional whitespace * GH-621 Fixes Main thread checks for permissions. (#640) * Swap version values on iOS This fixes #639 We were using the wrong version key/values from Info.plist for the respective AppInfo properties. * Ensure we only check is main thread when prompting * Revert "Swap version values on iOS" This reverts commit c61ef22. We actually have this correct. * Update nugetreadme.txt * Return distnct profiles. Added test as well. (#650) * Update README.md * Update README.md * GH-656: Connectivity Updates on Android for Not Available (#657) * Always check IsAvailable This may fix #656 on select phones where wifi is returned even though it isn't available. Still need to investigate profiles * removing whitespaces * [docs] Update global metadata for API docs (#659) * add global file metadata * update ms.topic * update topic to match .net docs * Update PULL_REQUEST_TEMPLATE.md * GH-668 Calculate Phone v Tablet on Android correctly (#670) Need to return known and calculate tablet vs phone as "Normal" is returned by all standard devices. * GH-672: Update SMS recipient (#674) * Add back constructor taking single recipient. * Update constructors * Clean up android xml * Update xamarin-essentials-android.xml * Update CONTRIBUTING.md (#692) * Set up CI with Azure Pipelines (#711) * Set up CI with Azure Pipelines * Added the first pass at the yaml * Typo * Make sure to sign only on the private bots * Use vmImage and not name * Fix a few errors * Restore as a separate step * Make sure not to build the samples on macos * Add some comments and other tweaks * Set the version to 1.0 to avoid the warnings * Use the centralized signing template * Use the xamarin endpoint * Check to see if there is a variable to access the current github endpoint * Use the new template * Build the library on windows/mac and the samples/tests just on windows * Update azure-pipelines.yml * Use more explicit job definitions * Update azure-pipelines.yml * Update azure-pipelines.yml * Tweak some audits to run in CI * More audit CI tweaks * More audit CI tweaks * Just a bit more tweaking to CI * [WIP] Xamarin.Essentials 1.1.0 (#663) * Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (#637) * GH-182 Color/Point/Rect/Size Extension Converters (#651) * Add extension helpers for iOS and Android * Add UWP colors and adjsut android colors. * Add UWP Point/Rect/Size * Rename and optimize! * Add tests and color helpers! * Fix unit test and add WithAlpha * Cleanup iOS as it stores it from 0-1 * Tests are all green! * Add generate-docs cmd :) * Add docs config to all :) * Additional clenaup for docs * Added some docs * Updated the mdoc target and regenerated the docs * Allow for code reuse on macOS (#665) Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported. * GH-196 Browser Customization (#646) * Implemented GH-196 * Apply suggestions from code review: Naming Renamed incorrectly spelled variables Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de> * Implemented GH-196 * Browser update work as requested. Using System.Drawing.Color now * Adopted more review changes. Type forwarded. * Review changes * Made equals operator null safe, removed constructor * Add documentation and simplify the API! * Update viewmodel * Back to 7.2 * GH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (#677) * Added bool IsFromMockProvider in Location class * Checkin * csproj original * Revert "csproj original" This reverts commit 6302b95. * Revert "Checkin" This reverts commit 0881e4f. * Revert "Added bool IsFromMockProvider in Location class" This reverts commit e56d940. * Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original; Adjust the property IsFromMockProvider in Location.shared and LocationExetensions. * Edited sample to show if the location is from moking provider. * Update docs * Fixes #694 (#699) * Update the mdoc to use the new minimum for VS2019 * GH-126: Finish Shake Detector API (#693) * Update CONTRIBUTING.md (#692) * GH-126 Detect Shake API (#666) * Added shaken support * name vhange * check-in * doc update * Implements the Shake API inside Accelerometer Class; Change sample to AccelorometerViewModel * Fix the sample project * Update the docs * Added Queue mechanism based off seismic with tests as well. Something is not right yet with calulating isaccelerating. * Finalize shake detection!!! * Re-generated the docs. * Fix the VM after merge * GH-704 Handle duplicate item in keychain (#705) * Update CONTRIBUTING.md (#692) * #704 if we get a duplicate item try to remove and then re-add if possible. * Add all possible combinations for coords to km or mile (#721) * Add all possible combinations for coords to km or mile * Update UnitConverters_Tests.cs * Use more explicit job definitions * Update UnitConverters_Tests.cs * GH-698 Set longer delay on connectivity changes - Android (#700) * Update CONTRIBUTING.md (#692) * Fixes #698 * Use original string instead of uri (#716) * GH-643: Add Android P targeting and support 28 support (#669) * Update PULL_REQUEST_TEMPLATE.md * Fixes #643 to add android P targeting and support 28 support * Add suppresses for Android P * Cleanup SDKs based on @Redth * Update more nugets * More optimizations for Retargeting * Refactor HasApiLevelN and updated support to 28.0.0.1 * Update manifest and key :) * Update the device tests certificates * Make sure to run the checks always * Updating the certs again to see if CI notices this time... * Change order to reflect enum (#735) * Lock keystore on Android for cipher (#734) * Add locks around android keystore. * move convert out of lock * GH-130 & GH-129: Android support for safe shareable file URI’s (#416) * Android: Support for safe shareable file URI’s On later versions of Android, you have to wrap streams of data you want to share outside your app (between apps) in a stream through a content provider. Android Support providers a general use FileProvider we can use for this. This commit basically adds support for getting all the right AndroidManifest declarations for the custom file provider based on the android support provider, so that we expose an internal method which gets a URI safe for sharing outside of the app. * Fix absolute type naming * Add a user interaction test for File Provider * Fix vibration code the ifdef meant an empty `else { }` statement with no `if { }` for platforms < 26. This fixes that. * Reorder using statements * Fix test attribute * Get provider authority properly * Added external storage permission * Change file provider path This is md5(“xamarin_essentials”) * Copy file into temp folder instead of file We keep the filename the same this way but use a GUID for a temp sub-folder to ensure a unique path. * Resgen * Permissions may need to be checked to control functionality * The Android FileProvider now can detect permissions - internal / external storage can be controlled - KitKat+ does not require the permissions - corrected the FileProvider resource xml * Added support for email attachments - support for a string path and native file types * Added attachments to the sample app * Updated the docs with the new types * Some fixes for iOS * Fix the mdoc target * regen docs * remove the obsolete armeabi ABI * Reworked the file logic to try and use public folders first - if the file is already exposed, then just use it directly - if the file is private, copy to an exposed location first - exposing the internal and external caches and the public/external files * Be more specific with the external storage permission name * Added some more depth to the comments here * Unnecessary else * Added base file info class * EmailAttachment now derives from FileBase * Added File Sharing * Keep track of IStorageFile internally * Prefer internal IStorageFile in UWP * Use attachment name properly in UWP * Add ctor to create from existing FileBase This will let us use UWP to create a new instance of something derived from FileBase with another instance of something else derived from FileBase, all while keeping track of the same `IStorageFile` instance. So we can conceivably do something like: ```csharp var mediaFile = await MediaPicker.PickPhotoAsync(); var attachment = new EmailAttachment(mediaFile); ``` * Add ctors for FileBase * Add ctors for ShareFileRequest * We can't use N on pre-N platforms * Updated the docs * Update some docs. * Bump * Gate Email/Share files with feature flags * Add sample for ShareFileRequest * Added test for share method in netstandard * [WIP] Adding the Device Tests to the yaml (#737) * Add the device tests to the yaml * Select the latest version of xamarin/xcode * Specify the iPhone simulator in the yaml * Install the Android emulator * Fix the shared test * try to resolve build issue with missing nuget * Fix docs * Fix ref * Trim . off start of extension for getting mimetype * Don't add empty strings on UWP to email (#738) * Cleanup UWP a bit * Update azure-pipelines.yml

Add back constructor taking single recipient.

da6920d

jamesmontemagno requested a review from mattleibow January 2, 2019 19:40

jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Jan 2, 2019

jamesmontemagno added this to the 1.0.1 milestone Jan 2, 2019

mattleibow approved these changes Jan 3, 2019

View reviewed changes

Mrnikbobjeff reviewed Jan 4, 2019

View reviewed changes

Xamarin.Essentials/Sms/Sms.shared.cs Show resolved Hide resolved

mattleibow previously requested changes Jan 4, 2019

View reviewed changes

Update constructors

f88f181

mattleibow approved these changes Jan 8, 2019

View reviewed changes

mattleibow previously requested changes Jan 8, 2019

View reviewed changes

Clean up android xml

854a792

Update xamarin-essentials-android.xml

1cb2515

mattleibow approved these changes Jan 8, 2019

View reviewed changes

jamesmontemagno merged commit 527cda6 into master Jan 8, 2019

jamesmontemagno deleted the feature/issue-672 branch January 8, 2019 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-672: Update SMS recipient #674

GH-672: Update SMS recipient #674

jamesmontemagno commented Jan 2, 2019 •

edited

VSC-Service-Account commented Jan 2, 2019

VSC-Service-Account commented Jan 2, 2019

VSC-Service-Account commented Jan 2, 2019

Mrnikbobjeff left a comment •

edited

mattleibow left a comment

Mrnikbobjeff commented Jan 7, 2019

VSC-Service-Account commented Jan 7, 2019

VSC-Service-Account commented Jan 7, 2019

VSC-Service-Account commented Jan 7, 2019

jamesmontemagno commented Jan 7, 2019

mattleibow Jan 8, 2019

jamesmontemagno Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

jamesmontemagno commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

mattleibow left a comment

VSC-Service-Account commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

GH-672: Update SMS recipient #674

GH-672: Update SMS recipient #674

Conversation

jamesmontemagno commented Jan 2, 2019 • edited

Description of Change

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

VSC-Service-Account commented Jan 2, 2019

VSC-Service-Account commented Jan 2, 2019

VSC-Service-Account commented Jan 2, 2019

✅ Validation status: passed

Mrnikbobjeff left a comment • edited

Choose a reason for hiding this comment

mattleibow left a comment

Choose a reason for hiding this comment

Mrnikbobjeff commented Jan 7, 2019

VSC-Service-Account commented Jan 7, 2019

VSC-Service-Account commented Jan 7, 2019

VSC-Service-Account commented Jan 7, 2019

✅ Validation status: passed

jamesmontemagno commented Jan 7, 2019

mattleibow Jan 8, 2019

Choose a reason for hiding this comment

jamesmontemagno Jan 8, 2019

Choose a reason for hiding this comment

VSC-Service-Account commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

✅ Validation status: passed

jamesmontemagno commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

mattleibow left a comment

Choose a reason for hiding this comment

VSC-Service-Account commented Jan 8, 2019

VSC-Service-Account commented Jan 8, 2019

✅ Validation status: passed

jamesmontemagno commented Jan 2, 2019 •

edited

Mrnikbobjeff left a comment •

edited