Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] ScrollViewRenderer HorizontalFadingEdgeEnabled ignored on horizontal ScrollView orientation #11185

Closed
lukashaertel opened this issue Jun 24, 2020 · 3 comments · Fixed by #11287
Labels
a/scrollview in-progress This issue has an associated pull request that may resolve it! s/unverified New report that has yet to be verified t/bug 🐛

Comments

@lukashaertel
Copy link

Description

Setting HorizontalFadingEdgeEnabled in a ScrollViewRenderer does not produce the expected result of fading the left and right edges on overflowing content. After looking into the source code, it appears that a second view is created for horizontal scroll behavior. The flags for controlling edge fading are not delegated to that view.

Steps to Reproduce

  1. Set a custom renderer for the ScrollView
  2. Set the HorizontalFadingEdgeEnabled to true and invoke SetFadingEdgeLength on element and orientation change

Expected Behavior

Left and right edge of the scrolled content should be faded out, if there is more content to scroll to.

Actual Behavior

The default look is still present. No edges are faded.

Basic Information

  • Version with issue: 4.6.0.800

Workaround

Overriding AddView in the renderer to intercept the actually used AHorizontalScrollView and setting the fading edge properties on that view resulted in the correct behavior of fading left and right edges.

@lukashaertel lukashaertel added s/unverified New report that has yet to be verified t/bug 🐛 labels Jun 24, 2020
@samhouts
Copy link
Member

Can you please attach a small project that demonstrates this issue? Thanks!

@samhouts samhouts added s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. labels Jun 26, 2020
@lukashaertel
Copy link
Author

Project to reproduce the bug:

hscrollfade.zip

@samhouts samhouts removed s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. s/needs-repro ❔ This reported issue doesn't include a sample project reproducing the issue. Please provide one. labels Jul 1, 2020
@rmarinho
Copy link
Member

rmarinho commented Jul 2, 2020

Thanks made a fix for it #11287

@rmarinho rmarinho linked a pull request Jul 2, 2020 that will close this issue
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/scrollview in-progress This issue has an associated pull request that may resolve it! s/unverified New report that has yet to be verified t/bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants