Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Pass fading properties to HorizontalScrollViewContainer #11287

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jul 2, 2020

Description of Change

We create a custom horizontal and need to pass it properties users set on custom renderers , properties like HorizontalFadingEdgeEnabled and HorizontalFadingEdgeLength

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

Should be able to see fading edge on scrollviewer

Before/After Screenshots

Not applicable

Testing Procedure

Manual visit issue 11185 and see if it shows the fading edges

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts merged commit 2b66939 into 4.8.0 Aug 4, 2020
@samhouts samhouts deleted the fix-11185 branch August 4, 2020 22:09
@samhouts samhouts added this to the 4.8.0 milestone Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ScrollViewRenderer HorizontalFadingEdgeEnabled ignored on horizontal ScrollView orientation
4 participants