This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix Frame IsClippedToBounds issue #11129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
approved these changes
Jun 29, 2020
samhouts
approved these changes
Jun 30, 2020
samhouts
added
the
approved
Has two approvals, no pending reviews, and no changes requested
label
Jun 30, 2020
When will you publish this solution? |
hartez
added
the
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
label
Jul 1, 2020
StephaneDelcroix
approved these changes
Jul 6, 2020
hartez
removed
the
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
label
Jul 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4.6.0
regression on 4.6.0
a/collectionview
a/frame
a/shell 🐚
a/visual
a/Xaml </>
approved
Has two approvals, no pending reviews, and no changes requested
ControlGallery
i/high
Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often
i/regression
p/Android
p/gtk
p/iOS 🍎
p/macOS
p/Tizen
p/UWP
p/WPF
t/bug 🐛
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Frame IsClippedToBounds issue on iOS.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
(The gif quality is low to keep a small size)
Testing Procedure
Launch Core Gallery and navigate to issue 11120. Toggle the CheckBox to use or not
IsClippedToBounds
in the Frame. If usingIsClippedToBounds
clip the buttons, the test has passed.PR Checklist