This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Xaml] Support native view declaration in Xaml #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
else | ||
{ | ||
} | ||
else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change in this, unnecessary diff
StephaneDelcroix
force-pushed
the
xaml-nativeview
branch
3 times, most recently
from
August 11, 2016 12:17
7e8d5f2
to
ef35a36
Compare
StephaneDelcroix
force-pushed
the
xaml-nativeview
branch
2 times, most recently
from
August 14, 2016 14:43
23e2832
to
e4ef5ed
Compare
StephaneDelcroix
force-pushed
the
xaml-nativeview
branch
6 times, most recently
from
September 2, 2016 08:37
37a9fef
to
6703f77
Compare
If you review this, review only the 2nd commit. the first is part of another PR |
xmlns:ios="clr-namespace:UIKit;assembly=Xamarin.iOS;targetPlatform=iOS" | ||
xmlns:androidWidget="clr-namespace:Android.Widget;assembly=Mono.Android;targetPlatform=Android" | ||
xmlns:formsandroid="clr-namespace:Xamarin.Forms;assembly=Xamarin.Forms.Platform.Android;targetPlatform=Android" | ||
xmlns:win="clr-namespace:Windows.UI.Xaml.Controls;assembly=Windows, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null, ContentType=WindowsRuntime;targetPlatform=Windows" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notice the targetPlatform
on these 4 lines. notice the cumbersome assembly name for uwp as well, but that's required to get it working
Allows including Native views directly in xaml. Support for ios, android, UWP
StephaneDelcroix
force-pushed
the
xaml-nativeview
branch
from
September 8, 2016 18:40
6703f77
to
57690aa
Compare
rmarinho
pushed a commit
that referenced
this pull request
Sep 13, 2016
Allows including Native views directly in xaml. Support for ios, android, UWP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With this PR, the following Xaml is valid, and works as expected:
That means 2 things:
Bugs Fixed
None
API Changes
None
Behavioral Changes
None
PR Checklist