[Android Maps] Make markers available to subclasses #3751

LRP-sgravel · 2018-09-09T13:37:37Z

Description of Change

Add method to retrieve native Marker from a pin in Android MapRenderer. No tests added as it is a simple Extract Method refactoring.

Issues Resolved

Eases subclassing of MapRenderer to extend pins. Needed to build a Skia Maps extension Nuget.

API Changes

Added:
protected Marker GetMarkerForPin(Pin pin)

Changed:
N/A

Removed:
N/A

Platforms Affected

Android

Behavioral/Visual Changes

None

Before/After Screenshots

N/A

Testing Procedure

N/A

PR Checklist

Has automated tests
Rebased on top of the target branch at time of PR
Changes adhere to coding standard

samhouts

Looks good! One request

Xamarin.Forms.Maps.Android/MapRenderer.cs

* Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault

…l bars (#3897) fixes #3843 * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72d. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Implemented for iOS, Android and MacOS * Implemented UAP and WPF * Refactored duplicate code and removed typo in method name * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72d. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Fixed code review comments * Removed obsolete convert method * Making sure default platform functionality is intact iOS and Android As er code review comments * Making sure default platform functionality is intact MacOS * Making sure default platform functionality is intact UWP and WPF * Code review comments for iOS, Android and MacOS Default platform value is now preserved and applied when setting is set to default * Code review comments UWP and WPF * Fix build * [UITest] - add ui test to test scroll permutations * [Uwp] fix bad merge * [wpf] fix spacing

* Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72d. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72d. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Removed touching the InputScope for the IsPassword property * Put back prediction settings * When InputScope was originally numeric, switch to numeric password scope, else we leave the previous logic in place * Fixed small error and added reproduction to gallery app * Fixed issues

* Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Update from origin (#11) * [Android] Enable MaxLines and TextDecorations on fast renderers (#3878) * enable MaxLines on fast renderers * added text decoration functionality * include test in project * [Enhancement] Create a bindable property for AutomationId (#3879) * create a bindable property for automationId * make ClassId and AutomationId properties of Element * add comments to .create-nuget.bat * added preserve attribute (#3876) fixes #2306 * [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656 * [Core] Use WeakEventManager on CanExecuteChanged * [Core]Add unit test for remove event handler with WeakEventManager * [Core] Fix remove the correct handler * [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808 - fixes #3808 * Prevent double time/date picker dialogs on Android when setting focus (#3899) * Prevent double time/date picker dialogs on Android when setting focus (#3899) * [Controls] Fix merge remove duplciated issue 3788 * WPF - Fix Unable to intercept back button (#3762) * WPF - Fix Unable to intercept back button * WPF - Improve OnBackButtonPressed -fixes #3689 * Fix Bugzilla38723 (#3812) fixes #2302 * [C] fix css mapping (#3919) * [Android] Fix UI test 1851 (#3882) * add preserve attribute - fixes #2255 * added using System * fixed spacing * use TestContentPage * fixed scope issues * [Android] Make native Android Platforms accessible via Context (#3364) * Make native Android Platforms accessible via Context * Add null checks * Added a disabled look to Android Toolbar Item images. (#3773) * Added a disabled look to Android Toolbar Item images. * Update NavigationPageRenderer.cs Refactored DisabledToolbarAlpha into a constant as requested. * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896) * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper * common code moved to VisualElementRenderer * rename interface fixes #3872 * [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141) * WPF - Ctrl+A does not select all in WPF password Entry (#3908) * [WPF] Fix Height of items not consistent (#3925) fixes #3913 * Fix StartTimer and Ticker for UWP (#3911) - fixes #1937 * Apply font fix for button and span (#3907) * added instructions (#3891) - fixes #2361 * [Android] Convert corner radius with correct pixel density (#3893) fixes #3884 * [Controls] Add Issue #3884 repo * [Android] Convert corner radius with correct pixel density fixes #3884 * [Controls] Update test message * WPF - Fix TimePicker with short time pattern shows verbose time (#3924) * Fix UI test 39378 (#3928) fixes #2305 * Update ClipBounds when View bounds changes (#3909) fixes #3717 * [C] catch AmbiguousMatchException on GetProps (#3915) - fixes #3870 * Automate UI test B45702 (#3914) fixes #2389 * automate 45702 * fix indentation * Fix bugzilla60787 (#3933) * [Android]Fix for frame renderer's bug (bugzilla 60787). #3902 https://bugzilla.xamarin.com/show_bug.cgi?id=60787 https://github.com/xamarin/Xamarin.Forms/issues/3902 * Add control to repro * PR fix * Build fix * Build fix for Xamarin.Forms.Core.Android.UITests * added instructions (#3926) * [UWP] fixes flyout menu on cell item (#3682) * Fix UI test B41424 needs instructions (#3942) * Add manual test steps and checks for ui test * step4Label text fix * [iOS] fix full width issues for TitleView (#3939) * [iOS] fix full width issues for TitleView * [iOS] simplified iOS 10 fixes #3881 fixes #3679 * Changes in TableView GTK Control to allow refresh the content (#3941) - fixes #3725 * Only set the Page Padding via SafeAreaInset on iOS (#3811) * only set the Page Padding via SafeAreaInset on iOS -fixes #3809 * [Controls] add waits for clicks in ui tests * [Controls] remove wrong category * [iOS] Move inset logic down into ios renderer * Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766 * Automate UI test 35127 (#3927) * automate test - fixes #2262 * indentation fix * indentation fix 2 * Make GetIconDrawable virtual (#3967) By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs. * [GTK] Fix visibility of hidden pages in the stack (#3904) When navigating to a new page, we should hide the previous content and show the new one so that the previous page renderer is not taken in account for redraws and resizes * [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936) * [Android] If MaxLines is not explicitly set, all LineBreakMode to set it; if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable default for native MaxLines when handling it via LineBreakMode. Consolidate MaxLines handling code between legacy and fast renderers. Remove unnecessary setting of SingleLine (which only applies to input). - fixes #3772 * Remove unnecessary maxLines setting * Handle resetting MaxLines to -1/default * Reinstate workaround for array bounds exception in older Android APIs * Fix UI test B43941 (#3889) * Add all platforms and remove non-deterministic behaviour * Return back correct check of counter * Endline fix * remove childPages list * [XamlC] avoid multiple subscription (#3969) Avoid multiple subscription to PropertyChanged on TypedBindings - fixes #3613 - fixes #3650 * Fix typos (mainly 'toogle' becoming 'toggle') (#3975) * Fix Issue2597 Needs UI Test (#3966) * Add test for issue 2597 * Fix space * Add CODEOWNERS * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842) * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840 - fixes #3840 * fixe formatting * [UITest] added UI Test * [Controls] adjusted UI Test button positions * [UITEST] simplify UI tests * [C] add CSS mapping for max-lines (#3991) - fixes #3982 * [iOS] Add ability to turn off updates to native controls from another thread (#3774) * [iOS] Add ability to turn off updates to native controls from another thread * Flip evaluation order fixes #1755 * Fixed NotImplementedException refreshing items in WPF ListView (#3962) * Fixed NotImplementedException refreshing items in WPF ListView * Small changes in ListView events subscription fixes #3309 fixes #3737 fixes #3648 * [GTK] Fix transparent background in visual elements (#3744) * Fix ActivityIndicator.IsRunning state (#4007) * add pdb for uap into nuget (#4015) * update GitInfo * [XamlC] don't compile bindings with Source (#3978) Sources are usually x:reference that can't be resolved at compilation time. - fixes #3606 * [Xaml[C]] resolve Extensions first (#3977) XamlLoader should first look for type with the Extension suffix. It used to be the case, but somehow regressed. - fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338 * [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984 * [Tizen] Add TabIndex implement for Tizen renderer (#4046) * [Tasks] multitarget the build tasks (#3895) - fixes #2690 - closes #2706 * [UITests] Update TestCloud.Agent (#4055) * [Tizen] Fix ProjectGuid for Forwarders (#4063) * [Tizen] Fix ProjectGuid for Forwarders * [Tizen] Make sure not to generate dependency file * Correct minor typo (#4068) * Added WebView Reload (#4013) fixes #3776 * Added WebView Reload * WebView Reload Added Tizen suport * [Tizen] Cleanup Code (#4080) * fixed ios editor placeholder font (#4009) * Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072) - fixes #2291 * [Xaml] Allow OnPlat markup in Styles (#3995) - fixes #3862 * [Xaml] fix Namescope being different than tree (#4089) As part of #2556, the namescoping tree was assumed to be equiv to the object tree, which is obviously wrong. This fixes it, while keeping the old behavior as a fallback. We might go further, but I can't come up with a reasonable scenario failing. - fixes #3821 * [Sample] [Android] Fixed PagesGallery.Droid build (#3999) * fixed PagesGallery.Droid build * Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place * updated project guid to lower case * Fix typeface reset issue (#4019) * Use ViewCompat to set and get label for view (#3996) * Removing LineBreakMode support from WindowsResourcesProvider (#4024) * Repro test page for 3979 * Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles * [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031 * [GTK] Add support for ClickGestureRecognizer (#3971) * [GTK] Add support for ClickGestureRecognizer * Add ClickGestureGalleryPage to test ClickGestureRecognizer * [iOS] Label TextColor has no effect with FormattedString (#4043) * https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string * https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case * Moved field and property to top - fixes #4040 * fix build, tentatively (#4117) * [Xaml] don't swallow exceptions from converters (#4100) Compiled converters are invoked, by reflection, at compile time. Any exception thrown there will be wrapped in a TargetInvocationException. When that happens, we still want to expose the inner XamlParseException to the user. - fixes #4099 * housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105) * Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106) * [Tizen] Fix Window alpha update timing (#4119) * [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331 * [WPF] Fixes `ControlTemplate` sizing issue (#2656) - fixes #2642 * Remove BOM from nuspec (#4128) * Navigation Page double Popped event Workaround (#3851) fixes #3509 * Navigation Page double Popped event Workaround * [UITest] Add UI Test * [Core] fix formatting * revert formatting fix * implemented workaround suggested by PureWeen * removed whitespace * moved ignorePopCall to a better location * [Enhancements] Toolbar a11y (#3974) fixes #1742 fixes #3795 * [Controls] Add automation id to icon * [iOS] Add AutomationId support to MDP tooggle button * [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage * [IOS] Refactor and add Accessibility to ToolbarItems * [iOS] Fix typos * [Android] Add accessibility to ToolbarItems * [UWP] Refactor A11y to extensions * [UWP] Set Accessibility properties on ToolbarItems * [UWP] Set accessibility to MDP button * [ControlGallery] Add accessibility toolbaritems to gallery * Comment test out * [iOS] Fix NRE when Control is being disposed * [UITests] Remove not used UITests file * Implementation of method ForceUpdateSize for Cell on macOS (#4104) * Implemented Cell ForceUpdateSize on macOS * Tab Styling * Prevent crash during setting NULL to element via interface method (#4179) - fixes #4178 - fixes #4146 * https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161) * [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109) * https://github.com/xamarin/Xamarin.Forms/issues/3930 fix * following convention * [Android] Fixes AutomationProperties.Name on Button (#4094) * [Android] Fixes AutomationProperties.Name on Button * [Android] Fixes for Switch control * UWP Toolbar dynamic overflow (#4022) * Adding Windows specific ToolbarDynamicOverflowEnabled configuration * Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers * Issue 3988 sample * Removed obsolete comment, cleaned up private and whitespace * Added toolbar dynamic overflow examples for master detail page and tabbed page - fixes #2057 - fixes #3988 * Add missing initial call to UpdateLineHeight; fixes #4136 (#4147) * Added UI test to B45027 (#4079) * Add UI test to B45027 * Changed execution of current UI test to Android platform * Added iOS UI test to B45027 * Refactored UI test execution * Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164) - fixes #3301 * [UWP] fixes entering text into SearchBar with UI Tests (#4173) * [UWP] fixes entering text into SearchBar with UI Tests * [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium * [UWP] Fix TitleView Width and MDP rendering quirks (#3987) * [UWP] Fix TitleView Width and MDP rendering quirks * [UWP] fix load timing for pushed pages and titleview * [UWP] move renderer check * [UWP] remove re-measure until 4116 fixed - fixes #3828 - fixes #3834 * [macOS] NRE in WebViewRenderer (#4188) fixes #4001 * https://github.com/xamarin/Xamarin.Forms/issues/4001 * fixed build * https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111) * [msbuild] use portable pdb files (#4201) Currently, on the first build of a "Hello World" Xamarin.Forms app, you will see this in the build log: ConvertDebuggingFiles Parameters Files C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb OutputItems _ConvertedDebuggingFiles C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll The logging is a little weird here, but this `ConvertDebuggingFiles` MSBuild task takes about 100ms on my machine. What is it doing? The Mono debugger can support two types of debugging files: - `mdb` files - "portable" `pdb` files If Xamarin.Android's build finds a "non-portable" `pdb` file, we have to run it through this task to convert to an `mdb` file... This gives us proper stacktraces for `FormsViewGroup.dll` and `Xamarin.Forms.Platform.Android.dll`. You can change the type of debugging symbols in your project with the `DebugType` setting, which has these options: - Blank or `None`: don't generate symbols. (Although Xamarin.Android has funny behavior here, see: https://github.com/xamarin/xamarin-android/issues/2282) - `Full` generates an `mdb` file, this is a Windows-proprietary format for debug builds - `PdbOnly` generates a "non-portable" `pdb` file, a Windows-proprietary format for release builds - `Portable` generates a "portable" pdb file, which is the new standard that works for debug and release builds. New SDK-style MSBuild projects use this option by default. These values are not case sensitive, I have mostly seen them lower case in newer projects. So what does Xamarin.Forms need to do? Use `<DebugType>portable</DebugType>` in any Android class library or app project. Other platforms, this is optional, not as much benefit. I have heard that `DebugType=portable` might cause a problem on UWP. * Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers won't pay the 100ms on initial build. * Initial build times for `Xamarin.Forms.sln` will be slightly better for development, although I didn't measure the difference here. * [XamlC] fix the argument match check for events (#4134) Well, it looks like the order of arguments of InheritOrImplements was reversed... a totally fine and normal Friday so far - fixes #4130 * Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251 * Add uitest for 2794 (#4110) fixes #2293 * Fix PropagateEvent value properly on Cells (#4191) * bump gitinfo * [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843 * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Implemented for iOS, Android and MacOS * Implemented UAP and WPF * Refactored duplicate code and removed typo in method name * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Fixed code review comments * Removed obsolete convert method * Making sure default platform functionality is intact iOS and Android As er code review comments * Making sure default platform functionality is intact MacOS * Making sure default platform functionality is intact UWP and WPF * Code review comments for iOS, Android and MacOS Default platform value is now preserved and applied when setting is set to default * Code review comments UWP and WPF * Fix build * [UITest] - add ui test to test scroll permutations * [Uwp] fix bad merge * [wpf] fix spacing * Adding instructions and UI tests for Bugzilla44461 (#4144) * Adding instructions and UI tests for Bugzilla44461 * Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs Co-Authored-By: mikescandy <michele.scandura@outlook.com> * Fix assert * [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215 if a type defines multiple op_implicit from the same type to different ones, trying to retrieve it with GetMethod() throws an AmbiguousMatchException. If this happens, we have to do the resolution ourself. - fixes #4215 * https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161) …

…leSection (#4379) fixes #2910 * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Update from origin (#11) * [Android] Enable MaxLines and TextDecorations on fast renderers (#3878) * enable MaxLines on fast renderers * added text decoration functionality * include test in project * [Enhancement] Create a bindable property for AutomationId (#3879) * create a bindable property for automationId * make ClassId and AutomationId properties of Element * add comments to .create-nuget.bat * added preserve attribute (#3876) fixes #2306 * [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656 * [Core] Use WeakEventManager on CanExecuteChanged * [Core]Add unit test for remove event handler with WeakEventManager * [Core] Fix remove the correct handler * [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808 - fixes #3808 * Prevent double time/date picker dialogs on Android when setting focus (#3899) * Prevent double time/date picker dialogs on Android when setting focus (#3899) * [Controls] Fix merge remove duplciated issue 3788 * WPF - Fix Unable to intercept back button (#3762) * WPF - Fix Unable to intercept back button * WPF - Improve OnBackButtonPressed -fixes #3689 * Fix Bugzilla38723 (#3812) fixes #2302 * [C] fix css mapping (#3919) * [Android] Fix UI test 1851 (#3882) * add preserve attribute - fixes #2255 * added using System * fixed spacing * use TestContentPage * fixed scope issues * [Android] Make native Android Platforms accessible via Context (#3364) * Make native Android Platforms accessible via Context * Add null checks * Added a disabled look to Android Toolbar Item images. (#3773) * Added a disabled look to Android Toolbar Item images. * Update NavigationPageRenderer.cs Refactored DisabledToolbarAlpha into a constant as requested. * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896) * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper * common code moved to VisualElementRenderer * rename interface fixes #3872 * [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141) * WPF - Ctrl+A does not select all in WPF password Entry (#3908) * [WPF] Fix Height of items not consistent (#3925) fixes #3913 * Fix StartTimer and Ticker for UWP (#3911) - fixes #1937 * Apply font fix for button and span (#3907) * added instructions (#3891) - fixes #2361 * [Android] Convert corner radius with correct pixel density (#3893) fixes #3884 * [Controls] Add Issue #3884 repo * [Android] Convert corner radius with correct pixel density fixes #3884 * [Controls] Update test message * WPF - Fix TimePicker with short time pattern shows verbose time (#3924) * Fix UI test 39378 (#3928) fixes #2305 * Update ClipBounds when View bounds changes (#3909) fixes #3717 * [C] catch AmbiguousMatchException on GetProps (#3915) - fixes #3870 * Automate UI test B45702 (#3914) fixes #2389 * automate 45702 * fix indentation * Fix bugzilla60787 (#3933) * [Android]Fix for frame renderer's bug (bugzilla 60787). #3902 https://bugzilla.xamarin.com/show_bug.cgi?id=60787 https://github.com/xamarin/Xamarin.Forms/issues/3902 * Add control to repro * PR fix * Build fix * Build fix for Xamarin.Forms.Core.Android.UITests * added instructions (#3926) * [UWP] fixes flyout menu on cell item (#3682) * Fix UI test B41424 needs instructions (#3942) * Add manual test steps and checks for ui test * step4Label text fix * [iOS] fix full width issues for TitleView (#3939) * [iOS] fix full width issues for TitleView * [iOS] simplified iOS 10 fixes #3881 fixes #3679 * Changes in TableView GTK Control to allow refresh the content (#3941) - fixes #3725 * Only set the Page Padding via SafeAreaInset on iOS (#3811) * only set the Page Padding via SafeAreaInset on iOS -fixes #3809 * [Controls] add waits for clicks in ui tests * [Controls] remove wrong category * [iOS] Move inset logic down into ios renderer * Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766 * Automate UI test 35127 (#3927) * automate test - fixes #2262 * indentation fix * indentation fix 2 * Make GetIconDrawable virtual (#3967) By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs. * [GTK] Fix visibility of hidden pages in the stack (#3904) When navigating to a new page, we should hide the previous content and show the new one so that the previous page renderer is not taken in account for redraws and resizes * [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936) * [Android] If MaxLines is not explicitly set, all LineBreakMode to set it; if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable default for native MaxLines when handling it via LineBreakMode. Consolidate MaxLines handling code between legacy and fast renderers. Remove unnecessary setting of SingleLine (which only applies to input). - fixes #3772 * Remove unnecessary maxLines setting * Handle resetting MaxLines to -1/default * Reinstate workaround for array bounds exception in older Android APIs * Fix UI test B43941 (#3889) * Add all platforms and remove non-deterministic behaviour * Return back correct check of counter * Endline fix * remove childPages list * [XamlC] avoid multiple subscription (#3969) Avoid multiple subscription to PropertyChanged on TypedBindings - fixes #3613 - fixes #3650 * Fix typos (mainly 'toogle' becoming 'toggle') (#3975) * Fix Issue2597 Needs UI Test (#3966) * Add test for issue 2597 * Fix space * Add CODEOWNERS * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842) * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840 - fixes #3840 * fixe formatting * [UITest] added UI Test * [Controls] adjusted UI Test button positions * [UITEST] simplify UI tests * [C] add CSS mapping for max-lines (#3991) - fixes #3982 * [iOS] Add ability to turn off updates to native controls from another thread (#3774) * [iOS] Add ability to turn off updates to native controls from another thread * Flip evaluation order fixes #1755 * Fixed NotImplementedException refreshing items in WPF ListView (#3962) * Fixed NotImplementedException refreshing items in WPF ListView * Small changes in ListView events subscription fixes #3309 fixes #3737 fixes #3648 * [GTK] Fix transparent background in visual elements (#3744) * Fix ActivityIndicator.IsRunning state (#4007) * add pdb for uap into nuget (#4015) * update GitInfo * [XamlC] don't compile bindings with Source (#3978) Sources are usually x:reference that can't be resolved at compilation time. - fixes #3606 * [Xaml[C]] resolve Extensions first (#3977) XamlLoader should first look for type with the Extension suffix. It used to be the case, but somehow regressed. - fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338 * [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984 * [Tizen] Add TabIndex implement for Tizen renderer (#4046) * [Tasks] multitarget the build tasks (#3895) - fixes #2690 - closes #2706 * [UITests] Update TestCloud.Agent (#4055) * [Tizen] Fix ProjectGuid for Forwarders (#4063) * [Tizen] Fix ProjectGuid for Forwarders * [Tizen] Make sure not to generate dependency file * Correct minor typo (#4068) * Added WebView Reload (#4013) fixes #3776 * Added WebView Reload * WebView Reload Added Tizen suport * [Tizen] Cleanup Code (#4080) * fixed ios editor placeholder font (#4009) * Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072) - fixes #2291 * [Xaml] Allow OnPlat markup in Styles (#3995) - fixes #3862 * [Xaml] fix Namescope being different than tree (#4089) As part of #2556, the namescoping tree was assumed to be equiv to the object tree, which is obviously wrong. This fixes it, while keeping the old behavior as a fallback. We might go further, but I can't come up with a reasonable scenario failing. - fixes #3821 * [Sample] [Android] Fixed PagesGallery.Droid build (#3999) * fixed PagesGallery.Droid build * Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place * updated project guid to lower case * Fix typeface reset issue (#4019) * Use ViewCompat to set and get label for view (#3996) * Removing LineBreakMode support from WindowsResourcesProvider (#4024) * Repro test page for 3979 * Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles * [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031 * [GTK] Add support for ClickGestureRecognizer (#3971) * [GTK] Add support for ClickGestureRecognizer * Add ClickGestureGalleryPage to test ClickGestureRecognizer * [iOS] Label TextColor has no effect with FormattedString (#4043) * https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string * https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case * Moved field and property to top - fixes #4040 * fix build, tentatively (#4117) * [Xaml] don't swallow exceptions from converters (#4100) Compiled converters are invoked, by reflection, at compile time. Any exception thrown there will be wrapped in a TargetInvocationException. When that happens, we still want to expose the inner XamlParseException to the user. - fixes #4099 * housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105) * Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106) * [Tizen] Fix Window alpha update timing (#4119) * [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331 * [WPF] Fixes `ControlTemplate` sizing issue (#2656) - fixes #2642 * Remove BOM from nuspec (#4128) * Navigation Page double Popped event Workaround (#3851) fixes #3509 * Navigation Page double Popped event Workaround * [UITest] Add UI Test * [Core] fix formatting * revert formatting fix * implemented workaround suggested by PureWeen * removed whitespace * moved ignorePopCall to a better location * [Enhancements] Toolbar a11y (#3974) fixes #1742 fixes #3795 * [Controls] Add automation id to icon * [iOS] Add AutomationId support to MDP tooggle button * [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage * [IOS] Refactor and add Accessibility to ToolbarItems * [iOS] Fix typos * [Android] Add accessibility to ToolbarItems * [UWP] Refactor A11y to extensions * [UWP] Set Accessibility properties on ToolbarItems * [UWP] Set accessibility to MDP button * [ControlGallery] Add accessibility toolbaritems to gallery * Comment test out * [iOS] Fix NRE when Control is being disposed * [UITests] Remove not used UITests file * Implementation of method ForceUpdateSize for Cell on macOS (#4104) * Implemented Cell ForceUpdateSize on macOS * Tab Styling * Prevent crash during setting NULL to element via interface method (#4179) - fixes #4178 - fixes #4146 * https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161) * [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109) * https://github.com/xamarin/Xamarin.Forms/issues/3930 fix * following convention * [Android] Fixes AutomationProperties.Name on Button (#4094) * [Android] Fixes AutomationProperties.Name on Button * [Android] Fixes for Switch control * UWP Toolbar dynamic overflow (#4022) * Adding Windows specific ToolbarDynamicOverflowEnabled configuration * Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers * Issue 3988 sample * Removed obsolete comment, cleaned up private and whitespace * Added toolbar dynamic overflow examples for master detail page and tabbed page - fixes #2057 - fixes #3988 * Add missing initial call to UpdateLineHeight; fixes #4136 (#4147) * Added UI test to B45027 (#4079) * Add UI test to B45027 * Changed execution of current UI test to Android platform * Added iOS UI test to B45027 * Refactored UI test execution * Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164) - fixes #3301 * [UWP] fixes entering text into SearchBar with UI Tests (#4173) * [UWP] fixes entering text into SearchBar with UI Tests * [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium * [UWP] Fix TitleView Width and MDP rendering quirks (#3987) * [UWP] Fix TitleView Width and MDP rendering quirks * [UWP] fix load timing for pushed pages and titleview * [UWP] move renderer check * [UWP] remove re-measure until 4116 fixed - fixes #3828 - fixes #3834 * [macOS] NRE in WebViewRenderer (#4188) fixes #4001 * https://github.com/xamarin/Xamarin.Forms/issues/4001 * fixed build * https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111) * [msbuild] use portable pdb files (#4201) Currently, on the first build of a "Hello World" Xamarin.Forms app, you will see this in the build log: ConvertDebuggingFiles Parameters Files C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb OutputItems _ConvertedDebuggingFiles C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll The logging is a little weird here, but this `ConvertDebuggingFiles` MSBuild task takes about 100ms on my machine. What is it doing? The Mono debugger can support two types of debugging files: - `mdb` files - "portable" `pdb` files If Xamarin.Android's build finds a "non-portable" `pdb` file, we have to run it through this task to convert to an `mdb` file... This gives us proper stacktraces for `FormsViewGroup.dll` and `Xamarin.Forms.Platform.Android.dll`. You can change the type of debugging symbols in your project with the `DebugType` setting, which has these options: - Blank or `None`: don't generate symbols. (Although Xamarin.Android has funny behavior here, see: https://github.com/xamarin/xamarin-android/issues/2282) - `Full` generates an `mdb` file, this is a Windows-proprietary format for debug builds - `PdbOnly` generates a "non-portable" `pdb` file, a Windows-proprietary format for release builds - `Portable` generates a "portable" pdb file, which is the new standard that works for debug and release builds. New SDK-style MSBuild projects use this option by default. These values are not case sensitive, I have mostly seen them lower case in newer projects. So what does Xamarin.Forms need to do? Use `<DebugType>portable</DebugType>` in any Android class library or app project. Other platforms, this is optional, not as much benefit. I have heard that `DebugType=portable` might cause a problem on UWP. * Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers won't pay the 100ms on initial build. * Initial build times for `Xamarin.Forms.sln` will be slightly better for development, although I didn't measure the difference here. * [XamlC] fix the argument match check for events (#4134) Well, it looks like the order of arguments of InheritOrImplements was reversed... a totally fine and normal Friday so far - fixes #4130 * Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251 * Add uitest for 2794 (#4110) fixes #2293 * Fix PropagateEvent value properly on Cells (#4191) * bump gitinfo * [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843 * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Implemented for iOS, Android and MacOS * Implemented UAP and WPF * Refactored duplicate code and removed typo in method name * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Fixed code review comments * Removed obsolete convert method * Making sure default platform functionality is intact iOS and Android As er code review comments * Making sure default platform functionality is intact MacOS * Making sure default platform functionality is intact UWP and WPF * Code review comments for iOS, Android and MacOS Default platform value is now preserved and applied when setting is set to default * Code review comments UWP and WPF * Fix build * [UITest] - add ui test to test scroll permutations * [Uwp] fix bad merge * [wpf] fix spacing * Adding instructions and UI tests for Bugzilla44461 (#4144) * Adding instructions and UI tests for Bugzilla44461 * Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs Co-Authored-By: mikescandy <michele.scandura@outlook.com> * Fix assert * [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215 if a type defines multiple op_implicit from the same type to different ones, trying to retrieve it with GetMethod() throws an AmbiguousMatchException. If this happens, we have to do the resolution ourself. - fixes #4215 * https://gi…

#4431) * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Update from origin (#11) * [Android] Enable MaxLines and TextDecorations on fast renderers (#3878) * enable MaxLines on fast renderers * added text decoration functionality * include test in project * [Enhancement] Create a bindable property for AutomationId (#3879) * create a bindable property for automationId * make ClassId and AutomationId properties of Element * add comments to .create-nuget.bat * added preserve attribute (#3876) fixes #2306 * [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656 * [Core] Use WeakEventManager on CanExecuteChanged * [Core]Add unit test for remove event handler with WeakEventManager * [Core] Fix remove the correct handler * [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808 - fixes #3808 * Prevent double time/date picker dialogs on Android when setting focus (#3899) * Prevent double time/date picker dialogs on Android when setting focus (#3899) * [Controls] Fix merge remove duplciated issue 3788 * WPF - Fix Unable to intercept back button (#3762) * WPF - Fix Unable to intercept back button * WPF - Improve OnBackButtonPressed -fixes #3689 * Fix Bugzilla38723 (#3812) fixes #2302 * [C] fix css mapping (#3919) * [Android] Fix UI test 1851 (#3882) * add preserve attribute - fixes #2255 * added using System * fixed spacing * use TestContentPage * fixed scope issues * [Android] Make native Android Platforms accessible via Context (#3364) * Make native Android Platforms accessible via Context * Add null checks * Added a disabled look to Android Toolbar Item images. (#3773) * Added a disabled look to Android Toolbar Item images. * Update NavigationPageRenderer.cs Refactored DisabledToolbarAlpha into a constant as requested. * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896) * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper * common code moved to VisualElementRenderer * rename interface fixes #3872 * [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141) * WPF - Ctrl+A does not select all in WPF password Entry (#3908) * [WPF] Fix Height of items not consistent (#3925) fixes #3913 * Fix StartTimer and Ticker for UWP (#3911) - fixes #1937 * Apply font fix for button and span (#3907) * added instructions (#3891) - fixes #2361 * [Android] Convert corner radius with correct pixel density (#3893) fixes #3884 * [Controls] Add Issue #3884 repo * [Android] Convert corner radius with correct pixel density fixes #3884 * [Controls] Update test message * WPF - Fix TimePicker with short time pattern shows verbose time (#3924) * Fix UI test 39378 (#3928) fixes #2305 * Update ClipBounds when View bounds changes (#3909) fixes #3717 * [C] catch AmbiguousMatchException on GetProps (#3915) - fixes #3870 * Automate UI test B45702 (#3914) fixes #2389 * automate 45702 * fix indentation * Fix bugzilla60787 (#3933) * [Android]Fix for frame renderer's bug (bugzilla 60787). #3902 https://bugzilla.xamarin.com/show_bug.cgi?id=60787 https://github.com/xamarin/Xamarin.Forms/issues/3902 * Add control to repro * PR fix * Build fix * Build fix for Xamarin.Forms.Core.Android.UITests * added instructions (#3926) * [UWP] fixes flyout menu on cell item (#3682) * Fix UI test B41424 needs instructions (#3942) * Add manual test steps and checks for ui test * step4Label text fix * [iOS] fix full width issues for TitleView (#3939) * [iOS] fix full width issues for TitleView * [iOS] simplified iOS 10 fixes #3881 fixes #3679 * Changes in TableView GTK Control to allow refresh the content (#3941) - fixes #3725 * Only set the Page Padding via SafeAreaInset on iOS (#3811) * only set the Page Padding via SafeAreaInset on iOS -fixes #3809 * [Controls] add waits for clicks in ui tests * [Controls] remove wrong category * [iOS] Move inset logic down into ios renderer * Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766 * Automate UI test 35127 (#3927) * automate test - fixes #2262 * indentation fix * indentation fix 2 * Make GetIconDrawable virtual (#3967) By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs. * [GTK] Fix visibility of hidden pages in the stack (#3904) When navigating to a new page, we should hide the previous content and show the new one so that the previous page renderer is not taken in account for redraws and resizes * [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936) * [Android] If MaxLines is not explicitly set, all LineBreakMode to set it; if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable default for native MaxLines when handling it via LineBreakMode. Consolidate MaxLines handling code between legacy and fast renderers. Remove unnecessary setting of SingleLine (which only applies to input). - fixes #3772 * Remove unnecessary maxLines setting * Handle resetting MaxLines to -1/default * Reinstate workaround for array bounds exception in older Android APIs * Fix UI test B43941 (#3889) * Add all platforms and remove non-deterministic behaviour * Return back correct check of counter * Endline fix * remove childPages list * [XamlC] avoid multiple subscription (#3969) Avoid multiple subscription to PropertyChanged on TypedBindings - fixes #3613 - fixes #3650 * Fix typos (mainly 'toogle' becoming 'toggle') (#3975) * Fix Issue2597 Needs UI Test (#3966) * Add test for issue 2597 * Fix space * Add CODEOWNERS * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842) * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840 - fixes #3840 * fixe formatting * [UITest] added UI Test * [Controls] adjusted UI Test button positions * [UITEST] simplify UI tests * [C] add CSS mapping for max-lines (#3991) - fixes #3982 * [iOS] Add ability to turn off updates to native controls from another thread (#3774) * [iOS] Add ability to turn off updates to native controls from another thread * Flip evaluation order fixes #1755 * Fixed NotImplementedException refreshing items in WPF ListView (#3962) * Fixed NotImplementedException refreshing items in WPF ListView * Small changes in ListView events subscription fixes #3309 fixes #3737 fixes #3648 * [GTK] Fix transparent background in visual elements (#3744) * Fix ActivityIndicator.IsRunning state (#4007) * add pdb for uap into nuget (#4015) * update GitInfo * [XamlC] don't compile bindings with Source (#3978) Sources are usually x:reference that can't be resolved at compilation time. - fixes #3606 * [Xaml[C]] resolve Extensions first (#3977) XamlLoader should first look for type with the Extension suffix. It used to be the case, but somehow regressed. - fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338 * [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984 * [Tizen] Add TabIndex implement for Tizen renderer (#4046) * [Tasks] multitarget the build tasks (#3895) - fixes #2690 - closes #2706 * [UITests] Update TestCloud.Agent (#4055) * [Tizen] Fix ProjectGuid for Forwarders (#4063) * [Tizen] Fix ProjectGuid for Forwarders * [Tizen] Make sure not to generate dependency file * Correct minor typo (#4068) * Added WebView Reload (#4013) fixes #3776 * Added WebView Reload * WebView Reload Added Tizen suport * [Tizen] Cleanup Code (#4080) * fixed ios editor placeholder font (#4009) * Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072) - fixes #2291 * [Xaml] Allow OnPlat markup in Styles (#3995) - fixes #3862 * [Xaml] fix Namescope being different than tree (#4089) As part of #2556, the namescoping tree was assumed to be equiv to the object tree, which is obviously wrong. This fixes it, while keeping the old behavior as a fallback. We might go further, but I can't come up with a reasonable scenario failing. - fixes #3821 * [Sample] [Android] Fixed PagesGallery.Droid build (#3999) * fixed PagesGallery.Droid build * Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place * updated project guid to lower case * Fix typeface reset issue (#4019) * Use ViewCompat to set and get label for view (#3996) * Removing LineBreakMode support from WindowsResourcesProvider (#4024) * Repro test page for 3979 * Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles * [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031 * [GTK] Add support for ClickGestureRecognizer (#3971) * [GTK] Add support for ClickGestureRecognizer * Add ClickGestureGalleryPage to test ClickGestureRecognizer * [iOS] Label TextColor has no effect with FormattedString (#4043) * https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string * https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case * Moved field and property to top - fixes #4040 * fix build, tentatively (#4117) * [Xaml] don't swallow exceptions from converters (#4100) Compiled converters are invoked, by reflection, at compile time. Any exception thrown there will be wrapped in a TargetInvocationException. When that happens, we still want to expose the inner XamlParseException to the user. - fixes #4099 * housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105) * Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106) * [Tizen] Fix Window alpha update timing (#4119) * [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331 * [WPF] Fixes `ControlTemplate` sizing issue (#2656) - fixes #2642 * Remove BOM from nuspec (#4128) * Navigation Page double Popped event Workaround (#3851) fixes #3509 * Navigation Page double Popped event Workaround * [UITest] Add UI Test * [Core] fix formatting * revert formatting fix * implemented workaround suggested by PureWeen * removed whitespace * moved ignorePopCall to a better location * [Enhancements] Toolbar a11y (#3974) fixes #1742 fixes #3795 * [Controls] Add automation id to icon * [iOS] Add AutomationId support to MDP tooggle button * [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage * [IOS] Refactor and add Accessibility to ToolbarItems * [iOS] Fix typos * [Android] Add accessibility to ToolbarItems * [UWP] Refactor A11y to extensions * [UWP] Set Accessibility properties on ToolbarItems * [UWP] Set accessibility to MDP button * [ControlGallery] Add accessibility toolbaritems to gallery * Comment test out * [iOS] Fix NRE when Control is being disposed * [UITests] Remove not used UITests file * Implementation of method ForceUpdateSize for Cell on macOS (#4104) * Implemented Cell ForceUpdateSize on macOS * Tab Styling * Prevent crash during setting NULL to element via interface method (#4179) - fixes #4178 - fixes #4146 * https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161) * [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109) * https://github.com/xamarin/Xamarin.Forms/issues/3930 fix * following convention * [Android] Fixes AutomationProperties.Name on Button (#4094) * [Android] Fixes AutomationProperties.Name on Button * [Android] Fixes for Switch control * UWP Toolbar dynamic overflow (#4022) * Adding Windows specific ToolbarDynamicOverflowEnabled configuration * Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers * Issue 3988 sample * Removed obsolete comment, cleaned up private and whitespace * Added toolbar dynamic overflow examples for master detail page and tabbed page - fixes #2057 - fixes #3988 * Add missing initial call to UpdateLineHeight; fixes #4136 (#4147) * Added UI test to B45027 (#4079) * Add UI test to B45027 * Changed execution of current UI test to Android platform * Added iOS UI test to B45027 * Refactored UI test execution * Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164) - fixes #3301 * [UWP] fixes entering text into SearchBar with UI Tests (#4173) * [UWP] fixes entering text into SearchBar with UI Tests * [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium * [UWP] Fix TitleView Width and MDP rendering quirks (#3987) * [UWP] Fix TitleView Width and MDP rendering quirks * [UWP] fix load timing for pushed pages and titleview * [UWP] move renderer check * [UWP] remove re-measure until 4116 fixed - fixes #3828 - fixes #3834 * [macOS] NRE in WebViewRenderer (#4188) fixes #4001 * https://github.com/xamarin/Xamarin.Forms/issues/4001 * fixed build * https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111) * [msbuild] use portable pdb files (#4201) Currently, on the first build of a "Hello World" Xamarin.Forms app, you will see this in the build log: ConvertDebuggingFiles Parameters Files C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb OutputItems _ConvertedDebuggingFiles C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll The logging is a little weird here, but this `ConvertDebuggingFiles` MSBuild task takes about 100ms on my machine. What is it doing? The Mono debugger can support two types of debugging files: - `mdb` files - "portable" `pdb` files If Xamarin.Android's build finds a "non-portable" `pdb` file, we have to run it through this task to convert to an `mdb` file... This gives us proper stacktraces for `FormsViewGroup.dll` and `Xamarin.Forms.Platform.Android.dll`. You can change the type of debugging symbols in your project with the `DebugType` setting, which has these options: - Blank or `None`: don't generate symbols. (Although Xamarin.Android has funny behavior here, see: https://github.com/xamarin/xamarin-android/issues/2282) - `Full` generates an `mdb` file, this is a Windows-proprietary format for debug builds - `PdbOnly` generates a "non-portable" `pdb` file, a Windows-proprietary format for release builds - `Portable` generates a "portable" pdb file, which is the new standard that works for debug and release builds. New SDK-style MSBuild projects use this option by default. These values are not case sensitive, I have mostly seen them lower case in newer projects. So what does Xamarin.Forms need to do? Use `<DebugType>portable</DebugType>` in any Android class library or app project. Other platforms, this is optional, not as much benefit. I have heard that `DebugType=portable` might cause a problem on UWP. * Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers won't pay the 100ms on initial build. * Initial build times for `Xamarin.Forms.sln` will be slightly better for development, although I didn't measure the difference here. * [XamlC] fix the argument match check for events (#4134) Well, it looks like the order of arguments of InheritOrImplements was reversed... a totally fine and normal Friday so far - fixes #4130 * Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251 * Add uitest for 2794 (#4110) fixes #2293 * Fix PropagateEvent value properly on Cells (#4191) * bump gitinfo * [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843 * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Implemented for iOS, Android and MacOS * Implemented UAP and WPF * Refactored duplicate code and removed typo in method name * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Fixed code review comments * Removed obsolete convert method * Making sure default platform functionality is intact iOS and Android As er code review comments * Making sure default platform functionality is intact MacOS * Making sure default platform functionality is intact UWP and WPF * Code review comments for iOS, Android and MacOS Default platform value is now preserved and applied when setting is set to default * Code review comments UWP and WPF * Fix build * [UITest] - add ui test to test scroll permutations * [Uwp] fix bad merge * [wpf] fix spacing * Adding instructions and UI tests for Bugzilla44461 (#4144) * Adding instructions and UI tests for Bugzilla44461 * Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs Co-Authored-By: mikescandy <michele.scandura@outlook.com> * Fix assert * [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215 if a type defines multiple op_implicit from the same type to different ones, trying to retrieve it with GetMethod() throws an AmbiguousMatchException. If this happens, we have to do the resolution ourself. - fixes #4215 * https://github.com/xamarin/Xam…

xamarin#4431) * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Update from origin (#11) * [Android] Enable MaxLines and TextDecorations on fast renderers (#3878) * enable MaxLines on fast renderers * added text decoration functionality * include test in project * [Enhancement] Create a bindable property for AutomationId (#3879) * create a bindable property for automationId * make ClassId and AutomationId properties of Element * add comments to .create-nuget.bat * added preserve attribute (#3876) fixes #2306 * [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (#3852) fixes #3656 * [Core] Use WeakEventManager on CanExecuteChanged * [Core]Add unit test for remove event handler with WeakEventManager * [Core] Fix remove the correct handler * [CSS] accept 'oblique' for 'font-style' (#3815) fixes #3808 - fixes #3808 * Prevent double time/date picker dialogs on Android when setting focus (#3899) * Prevent double time/date picker dialogs on Android when setting focus (#3899) * [Controls] Fix merge remove duplciated issue 3788 * WPF - Fix Unable to intercept back button (#3762) * WPF - Fix Unable to intercept back button * WPF - Improve OnBackButtonPressed -fixes #3689 * Fix Bugzilla38723 (#3812) fixes #2302 * [C] fix css mapping (#3919) * [Android] Fix UI test 1851 (#3882) * add preserve attribute - fixes #2255 * added using System * fixed spacing * use TestContentPage * fixed scope issues * [Android] Make native Android Platforms accessible via Context (#3364) * Make native Android Platforms accessible via Context * Add null checks * Added a disabled look to Android Toolbar Item images. (#3773) * Added a disabled look to Android Toolbar Item images. * Update NavigationPageRenderer.cs Refactored DisabledToolbarAlpha into a constant as requested. * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (#3896) * [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper * common code moved to VisualElementRenderer * rename interface fixes #3872 * [UWP] For the Slider default value of step is set to 1000 to match Android. (#3141) * WPF - Ctrl+A does not select all in WPF password Entry (#3908) * [WPF] Fix Height of items not consistent (#3925) fixes #3913 * Fix StartTimer and Ticker for UWP (#3911) - fixes #1937 * Apply font fix for button and span (#3907) * added instructions (#3891) - fixes #2361 * [Android] Convert corner radius with correct pixel density (#3893) fixes #3884 * [Controls] Add Issue #3884 repo * [Android] Convert corner radius with correct pixel density fixes #3884 * [Controls] Update test message * WPF - Fix TimePicker with short time pattern shows verbose time (#3924) * Fix UI test 39378 (#3928) fixes #2305 * Update ClipBounds when View bounds changes (#3909) fixes #3717 * [C] catch AmbiguousMatchException on GetProps (#3915) - fixes #3870 * Automate UI test B45702 (#3914) fixes #2389 * automate 45702 * fix indentation * Fix bugzilla60787 (#3933) * [Android]Fix for frame renderer's bug (bugzilla 60787). #3902 https://bugzilla.xamarin.com/show_bug.cgi?id=60787 https://github.com/xamarin/Xamarin.Forms/issues/3902 * Add control to repro * PR fix * Build fix * Build fix for Xamarin.Forms.Core.Android.UITests * added instructions (#3926) * [UWP] fixes flyout menu on cell item (#3682) * Fix UI test B41424 needs instructions (#3942) * Add manual test steps and checks for ui test * step4Label text fix * [iOS] fix full width issues for TitleView (#3939) * [iOS] fix full width issues for TitleView * [iOS] simplified iOS 10 fixes #3881 fixes #3679 * Changes in TableView GTK Control to allow refresh the content (#3941) - fixes #3725 * Only set the Page Padding via SafeAreaInset on iOS (#3811) * only set the Page Padding via SafeAreaInset on iOS -fixes #3809 * [Controls] add waits for clicks in ui tests * [Controls] remove wrong category * [iOS] Move inset logic down into ios renderer * Added logic to allow set the ListView SelectedIndex (#3948) fixes #3766 * Automate UI test 35127 (#3927) * automate test - fixes #2262 * indentation fix * indentation fix 2 * Make GetIconDrawable virtual (#3967) By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs. * [GTK] Fix visibility of hidden pages in the stack (#3904) When navigating to a new page, we should hide the previous content and show the new one so that the previous page renderer is not taken in account for redraws and resizes * [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (#3936) * [Android] If MaxLines is not explicitly set, all LineBreakMode to set it; if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable default for native MaxLines when handling it via LineBreakMode. Consolidate MaxLines handling code between legacy and fast renderers. Remove unnecessary setting of SingleLine (which only applies to input). - fixes #3772 * Remove unnecessary maxLines setting * Handle resetting MaxLines to -1/default * Reinstate workaround for array bounds exception in older Android APIs * Fix UI test B43941 (#3889) * Add all platforms and remove non-deterministic behaviour * Return back correct check of counter * Endline fix * remove childPages list * [XamlC] avoid multiple subscription (#3969) Avoid multiple subscription to PropertyChanged on TypedBindings - fixes #3613 - fixes #3650 * Fix typos (mainly 'toogle' becoming 'toggle') (#3975) * Fix Issue2597 Needs UI Test (#3966) * Add test for issue 2597 * Fix space * Add CODEOWNERS * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842) * Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840 - fixes #3840 * fixe formatting * [UITest] added UI Test * [Controls] adjusted UI Test button positions * [UITEST] simplify UI tests * [C] add CSS mapping for max-lines (#3991) - fixes #3982 * [iOS] Add ability to turn off updates to native controls from another thread (#3774) * [iOS] Add ability to turn off updates to native controls from another thread * Flip evaluation order fixes #1755 * Fixed NotImplementedException refreshing items in WPF ListView (#3962) * Fixed NotImplementedException refreshing items in WPF ListView * Small changes in ListView events subscription fixes #3309 fixes #3737 fixes #3648 * [GTK] Fix transparent background in visual elements (#3744) * Fix ActivityIndicator.IsRunning state (#4007) * add pdb for uap into nuget (#4015) * update GitInfo * [XamlC] don't compile bindings with Source (#3978) Sources are usually x:reference that can't be resolved at compilation time. - fixes #3606 * [Xaml[C]] resolve Extensions first (#3977) XamlLoader should first look for type with the Extension suffix. It used to be the case, but somehow regressed. - fixes https://github.com/xamarin/Xamarin.Forms/issues/3606#issuecomment-422377338 * [UWP] Document in the README.md the steps required to run UI Tests (#4014) fixes #3984 * [Tizen] Add TabIndex implement for Tizen renderer (#4046) * [Tasks] multitarget the build tasks (#3895) - fixes #2690 - closes #2706 * [UITests] Update TestCloud.Agent (#4055) * [Tizen] Fix ProjectGuid for Forwarders (#4063) * [Tizen] Fix ProjectGuid for Forwarders * [Tizen] Make sure not to generate dependency file * Correct minor typo (#4068) * Added WebView Reload (#4013) fixes #3776 * Added WebView Reload * WebView Reload Added Tizen suport * [Tizen] Cleanup Code (#4080) * fixed ios editor placeholder font (#4009) * Prevented crash https://github.com/xamarin/Xamarin.Forms/issues/2291 (#4072) - fixes #2291 * [Xaml] Allow OnPlat markup in Styles (#3995) - fixes #3862 * [Xaml] fix Namescope being different than tree (#4089) As part of #2556, the namescoping tree was assumed to be equiv to the object tree, which is obviously wrong. This fixes it, while keeping the old behavior as a fallback. We might go further, but I can't come up with a reasonable scenario failing. - fixes #3821 * [Sample] [Android] Fixed PagesGallery.Droid build (#3999) * fixed PagesGallery.Droid build * Moved Xamarin.Forms.Platform.Android (Forwarders) reference to previous place * updated project guid to lower case * Fix typeface reset issue (#4019) * Use ViewCompat to set and get label for view (#3996) * Removing LineBreakMode support from WindowsResourcesProvider (#4024) * Repro test page for 3979 * Removes LineBreakMode support from WindowsResourcesProvider as it is inconsistent with other platforms and caused issues when setting Span style to the default Device Styles * [macOS] Fix NRE on Mojave when aligning the tile (#4086) fixes #3031 * [GTK] Add support for ClickGestureRecognizer (#3971) * [GTK] Add support for ClickGestureRecognizer * Add ClickGestureGalleryPage to test ClickGestureRecognizer * [iOS] Label TextColor has no effect with FormattedString (#4043) * https://github.com/xamarin/Xamarin.Forms/issues/4040 fix default font/color for formatted string * https://github.com/xamarin/Xamarin.Forms/pull/4043 fixed naming, added test case * Moved field and property to top - fixes #4040 * fix build, tentatively (#4117) * [Xaml] don't swallow exceptions from converters (#4100) Compiled converters are invoked, by reflection, at compile time. Any exception thrown there will be wrapped in a TargetInvocationException. When that happens, we still want to expose the inner XamlParseException to the user. - fixes #4099 * housekeeping ended with https://github.com/xamarin/Xamarin.Forms/pull/3999 (#4105) * Bump minimum Microsoft.NETCore.UniversalWindowsPlatform version to 6.0.12 (#4106) * [Tizen] Fix Window alpha update timing (#4119) * [UWP] fixed `MinimumDate` and `MaximumDate` properties of DatePicker (#3683) fixes #3331 * [WPF] Fixes `ControlTemplate` sizing issue (#2656) - fixes #2642 * Remove BOM from nuspec (#4128) * Navigation Page double Popped event Workaround (#3851) fixes #3509 * Navigation Page double Popped event Workaround * [UITest] Add UI Test * [Core] fix formatting * revert formatting fix * implemented workaround suggested by PureWeen * removed whitespace * moved ignorePopCall to a better location * [Enhancements] Toolbar a11y (#3974) fixes #1742 fixes #3795 * [Controls] Add automation id to icon * [iOS] Add AutomationId support to MDP tooggle button * [Android] Add support for AutomationId to ActionBarDrawerToggle and MasterDetailPage * [IOS] Refactor and add Accessibility to ToolbarItems * [iOS] Fix typos * [Android] Add accessibility to ToolbarItems * [UWP] Refactor A11y to extensions * [UWP] Set Accessibility properties on ToolbarItems * [UWP] Set accessibility to MDP button * [ControlGallery] Add accessibility toolbaritems to gallery * Comment test out * [iOS] Fix NRE when Control is being disposed * [UITests] Remove not used UITests file * Implementation of method ForceUpdateSize for Cell on macOS (#4104) * Implemented Cell ForceUpdateSize on macOS * Tab Styling * Prevent crash during setting NULL to element via interface method (#4179) - fixes #4178 - fixes #4146 * https://github.com/xamarin/Xamarin.Forms/issues/4076 fix (#4161) * [iOS] Rapidly clicking span (6 times at least) on UITest 3525 throws a null exception (#4109) * https://github.com/xamarin/Xamarin.Forms/issues/3930 fix * following convention * [Android] Fixes AutomationProperties.Name on Button (#4094) * [Android] Fixes AutomationProperties.Name on Button * [Android] Fixes for Switch control * UWP Toolbar dynamic overflow (#4022) * Adding Windows specific ToolbarDynamicOverflowEnabled configuration * Enabled ToolbarDynamicOverflowEnabled (pun intended) on page controls and renderers * Issue 3988 sample * Removed obsolete comment, cleaned up private and whitespace * Added toolbar dynamic overflow examples for master detail page and tabbed page - fixes #2057 - fixes #3988 * Add missing initial call to UpdateLineHeight; fixes #4136 (#4147) * Added UI test to B45027 (#4079) * Add UI test to B45027 * Changed execution of current UI test to Android platform * Added iOS UI test to B45027 * Refactored UI test execution * Fix https://github.com/xamarin/Xamarin.Forms/issues/3301 (#4164) - fixes #3301 * [UWP] fixes entering text into SearchBar with UI Tests (#4173) * [UWP] fixes entering text into SearchBar with UI Tests * [UWP] ITabStopOnDescendants - fixed selection when setting focus from Selenium * [UWP] Fix TitleView Width and MDP rendering quirks (#3987) * [UWP] Fix TitleView Width and MDP rendering quirks * [UWP] fix load timing for pushed pages and titleview * [UWP] move renderer check * [UWP] remove re-measure until 4116 fixed - fixes #3828 - fixes #3834 * [macOS] NRE in WebViewRenderer (#4188) fixes #4001 * https://github.com/xamarin/Xamarin.Forms/issues/4001 * fixed build * https://github.com/xamarin/Xamarin.Forms/issues/2831 fixes #2831 (#4111) * [msbuild] use portable pdb files (#4201) Currently, on the first build of a "Hello World" Xamarin.Forms app, you will see this in the build log: ConvertDebuggingFiles Parameters Files C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.pdb C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.pdb OutputItems _ConvertedDebuggingFiles C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\FormsViewGroup.dll C:\Users\myuser\.nuget\packages\xamarin.forms\3.1.0.697729\lib\MonoAndroid10\Xamarin.Forms.Platform.Android.dll The logging is a little weird here, but this `ConvertDebuggingFiles` MSBuild task takes about 100ms on my machine. What is it doing? The Mono debugger can support two types of debugging files: - `mdb` files - "portable" `pdb` files If Xamarin.Android's build finds a "non-portable" `pdb` file, we have to run it through this task to convert to an `mdb` file... This gives us proper stacktraces for `FormsViewGroup.dll` and `Xamarin.Forms.Platform.Android.dll`. You can change the type of debugging symbols in your project with the `DebugType` setting, which has these options: - Blank or `None`: don't generate symbols. (Although Xamarin.Android has funny behavior here, see: https://github.com/xamarin/xamarin-android/issues/2282) - `Full` generates an `mdb` file, this is a Windows-proprietary format for debug builds - `PdbOnly` generates a "non-portable" `pdb` file, a Windows-proprietary format for release builds - `Portable` generates a "portable" pdb file, which is the new standard that works for debug and release builds. New SDK-style MSBuild projects use this option by default. These values are not case sensitive, I have mostly seen them lower case in newer projects. So what does Xamarin.Forms need to do? Use `<DebugType>portable</DebugType>` in any Android class library or app project. Other platforms, this is optional, not as much benefit. I have heard that `DebugType=portable` might cause a problem on UWP. * Xamarin.Forms will ship "portable" `pdbs` in its NuGet package for `FormsViewGroup.dll` and `Xamarin.Forms.*.Android.dll`. Developers won't pay the 100ms on initial build. * Initial build times for `Xamarin.Forms.sln` will be slightly better for development, although I didn't measure the difference here. * [XamlC] fix the argument match check for events (#4134) Well, it looks like the order of arguments of InheritOrImplements was reversed... a totally fine and normal Friday so far - fixes #4130 * Add UI Test. Add instructions. Move to correct namespace (#4170) fixes #2251 * Add uitest for 2794 (#4110) fixes #2293 * Fix PropagateEvent value properly on Cells (#4191) * bump gitinfo * [Core, iOS, MacOS, Android, UWP, WPF] ListView hide scroll view scroll bars (#3897) fixes #3843 * Update from origin (#8) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Implemented for iOS, Android and MacOS * Implemented UAP and WPF * Refactored duplicate code and removed typo in method name * Update from origin (#9) * [C] VisibilityConverter Trims input (#3581) For CSS purposes, the VisibilityConverter was added, and actually replaced the `Boolean.Parse(str)` call for parsing Visibility. `Boolean.Parse()` trims input, and the converter was not, so this was a regression. This changes Trim() the input, to be fully backward compatible. - fixes #3554 * Ensure ConstructorCountId and TimeId elements are available before querying them (#3588) * For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589) This would allow previewer/designer/reloader to determine the source of a stylesheet and refresh its content when appropriate. * Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)" This reverts commit f66a72de5b475a6a8387a80e418997b38dc40d4c. * Fix NRE; Ret 0 if Text null (#3594) fixes #3579 * [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704 * [Core] Ignore Shamehat target when running DesignTimeBuild (#3605) * [XamlC] Fix binding compilation fo value types (#3551) properly load valuetype arguments of generated setters, using ldarg, instead of ldarga. - fixes #3539 * Update PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * [Android] Fix Label LineHeight (#3452) * fix line height android * Make UAP respect initial LineHeight * update .create-nuget.bat (#3638) * Add Null Check to GetRenderer (#3575) - fix #3563 * Fix 3562 Null Reference Exception (#3576) - fixes #3562 * Fix 3564 Null Reference Exception (#3578) - fixes #3564 * [iOS] AutomationProperty support for cells (#3313) fixes #3296 * [iOS] AutomationProperty support for cells * Add test case to AutomationProperties gallery * [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514) * [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641) * [C] Set binding context on Span Gestures (#3639) * [Core] Set binding context on Span Gestures * [Core] Simplify loop setting child binding context - fixes #3524 * Update PULL_REQUEST_TEMPLATE.md * [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672) * [iOS] iPad ActionSheet should always have a Cancel method (#3636) * Add repro for #3049 * [iOS] iPad ActionSheet should always have a Cancel method fixes #3049 * [Android] fixes #3675 - set initial ScrollView Scroll values when RTL (#3676) * [Android] API check for Shadow properties on Button (#3617) fixes #2702 * [Android] API check for Shadow properties on Button * Fix swapped shadow values * [iOS] fixes #3525 - add epsilon for float compare (#3654) * [iOS] fixes #3525 - add epsilon for float compare and make region immutable * [ControlGallery] spread out spans to account for click slop * [ControlGallery] - adjust span slightly for android test * [Core] remove private * Fix text wrapping (#3671) fixes #3634 * [GTK] Fix navigation bar visibility updates (#3651) * Fix partially #3585 (#3592) * Make webkit-sharp.dll.config cross-platform * Update webkit-sharp.dll with missing signals bindings see: https://github.com/ylatuya/webkit-sharp/tree/fluendo * [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643) * [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases * [Core] remove ChildGestureRecognizers when spans get removed * [iOS] removed incorrect return from null * Fixes #3663 (#3684) * Fix ScrollView Padding issue (#3685) * [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267 * Fix [WPF] Memory leak when you pop a TabbedPage * Update ViewRenderer.cs * Update ViewRenderer.cs * [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633 * Add repro for #3343 + unit tests * [Core] Disallow negative values for CursorPosition/SelectionLength * [All] CursorPosition/SelectionLength can bindin ctor & clear value fixes #3343 * typo * cleanup * [iOS] Cursor snaps to end * try/catch * [CSS] add more properties (#3466) map new CSS properties: - `color` on `IColorElement` (`ActivityIndicator`, `BoxView`), `ProgressBar` and `Switch` - `row-gap` and `column-gap` on `Grid` - `transform` and `transform-origin` on `VisualElement` - `vertical-align` on `Label` add new XF-specific CSS properties - `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`, `SearchBar` - `-xf-max-length` on `InputView` (`Editor` and `Entry`) - `-xf-bar-background-color` and `-xf-bar-text-color` on `NavigationPage` and `TabbedPage` - `-xf-orientation` on `ScrollView` and `StackLayout` - `-xf-horizontal-scroll-bar-visibility` and `-xf-vertical-scroll-bar-visibility` on `ScrollView` - `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color` on `Slider` - `-xf-spacing` on `StackLayout` This PR replaces and closes #3276 - fixes #2891 * [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139 * [Controls] Add reproduction and test case for issue #3413 * [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3 * [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width * [Controls] Fix spelling and add Manual Review to the test of #3413 * [iOS] Simplify code for UISearchBar width * [iOS] Return always some width from measure the UISearchBar on IOS * [Controls] Add reproduction case for issue #2139 * [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616 * [Android] Support multiple clipping settings in single layout (#3559) * Repro * Fix for API 18+ * [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518) * [Controls] Add repo of issue #3408 * [iOS] Unsubscribe CellPropertyChanged when cell is disposed * [Controls] Add issue to project * [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers * [Controls] Simplify Issue * [iOS] Remove PropertyChanged that was not used * [Controls] add check for null binding on template, add notes about issues * [Controls] added reference to Android crash * [iOS]Use existing PropertyChanged on ViewCelRenderer * [iOS] Keep the existing override so we don't break users * Update TextCellRenderer.cs * update submodule * 24H Mode (#3701) The 24h mode for the pickerdialog was not working. Version 3.1 was working fine. Here is an updated file. * [UWP] uncomment tests that are now passing for 3188 (#3723) * [UITest] Update Xamarin.UITest nuget package (#3632) * [UITests] Update Xamarin.UITest 2.2.5 * [UITests] Try fix Toolbaritems * [UITest] Update to 2.2.5-1606 * [UITests] Small Fixes and workarounds to make uitest happy * [UITests ] Add delay to 1733 for API28 * [Android] Revert bad merge (#3746) fixes #3705 * [Android, iOS] Fixes layout compression causes (#3698) fixes #3624 * [Android, iOS] Fixes layout compression causes * [iOS] improve UpdateNewElement method * Fix build error hopefully * [UWP] Fixes CollectionChanged events in ListView (#3323) * fixes #3273 * [UWP] Fixes CollectionChanged events in ListView * a wrapped collection is used only if the SourceItem is not ObservableCollection * improve uitest * fixed NRE in empty ListView * added a sortable custom renderer for UItest * minor refactoring * fixed reset of not wrapped collections * addressing comments * [UWP] remove WinRT hack * [UWP] add missing using and cleanup additional resources * [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629 * [Build] Update provisioning * [Controls] Ignore deprecated Android API usage * [Android] Remove use of obsolete color usage * [Android] Remove app fragment usage * [android] Rollback changes to EntryCellRenderer * [Android] Better way to get the default color for the label text * [Android] Obsolete message for ContentPage.CreateFragment() * [ControlGallery] - create bitmap from Drawable to use for pixel location * [Android] Use textcolor resource * Update submodule * Fix tests (#3771) * [ControlGallery] Wait for element and add timing to tests * [iOS] Fix NRE on RenderPool * Add TabStop/TabIndex (#2795) * [Core, UWP, Android] support TabStop/TabIndex * removing linq * add iOS / MacOS implementation * add WPF implementation fixes UWP implementation * - addressing comments - improve test - optimizations - added previous tab direction in same tab group * addressing comments * [Android] support tabstop for pickers * - moving shared code to a static class - removed reflection * ITabStop -> changed to internal, renamed, added in to fastRenderers * Update ITabStop to be public * Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756 * [iOS] Fix NRE on ContextCell (#3714) fixes #3275 * [Controls] Add repo for issue #3275 * [iOS] Fix NRE when no gestures exist on table * [iOS] Null check outside loop * [iOS]Make sure to dispose/unhook when we are removed from UITableView. * Update submodule * [iOS] Don't double dispose ContextActionCell * WPF - Fix Width and Height measurement when GetDesiredSize (#3750) * WPF - Reset Width and Height when GetDesiredSize * Some formatting changes * Add APP directive * [WPF]Fix build * [Android Maps] Make markers available to subclasses (#3751) * Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault * [UITests] wait for element before querying for it (#3791) * [UITests] wait for element before querying for it * [Controls] generalize and better represent intended behavior * WPF - Fix Local store not persistant when restarting App (#3752) -fixes #3541 * WPF - Fix Local store not persistant when restarting App * Add UITest * [Controls] Add automated UI Test * [UITests] Isolate test 3408 * [UITest] Update Xamarin UITest packages * [UWP] implement Replace without reloading ListView (#3792) -fixes #3788 * [UWP] implement Replace without reloading ListView * [UWP] extract bindingcontext of new item for replace * [iOS] Use UIApperance default color for UISwitch (#3819) * [Controls] Set default color of UISwitch to Red * [iOS] Use default color from Apperance API * [UITests] replace awaits with more reliable WaitForElement (#3835) * [Core] Propagate BindingContext changes to TitleView (#3823) * [Core] Propagate BindingContext changes to TitleView * [Tests] Move UI test to Core Unit Test * [A] do not draw gradient for empty CornerRadius (#3786) Drawing CornerRadius (introduce by #1998) when the CornerRadii are actually 0 causes scaling artifacts on API < 25. This fixes the regression when no CornerRadius is set. Expect blurry border scaling with CornerRadius not empty and API < 25 - fixes #3781 * [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780) * Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted * Changed _webViewClient and GetWebViewClient() method to return base class * Changed public things to protected internal * Fix spaces to tabs indentation to match the coding style (#3745) * [Build] Fix merge * Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097 * Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603 * Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it * Remove `RemoveAllViews` from `Dispose` * Fixed code review comments * Removed obsolete convert method * Making sure default platform functionality is intact iOS and Android As er code review comments * Making sure default platform functionality is intact MacOS * Making sure default platform functionality is intact UWP and WPF * Code review comments for iOS, Android and MacOS Default platform value is now preserved and applied when setting is set to default * Code review comments UWP and WPF * Fix build * [UITest] - add ui test to test scroll permutations * [Uwp] fix bad merge * [wpf] fix spacing * Adding instructions and UI tests for Bugzilla44461 (#4144) * Adding instructions and UI tests for Bugzilla44461 * Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44461.cs Co-Authored-By: mikescandy <michele.scandura@outlook.com> * Fix assert * [C] avoid AmbiguousMatchexception in Bindings (#4216) fixes #4215 if a type defines multiple op_implicit from the same type to different ones, trying to retrieve it with GetMethod() throws an AmbiguousMatchException. If this happens, we have to do the resolution ourself. - fixes #4215 * https://github.com/xamarin/Xam…

LRP-sgravel added 2 commits September 9, 2018 09:25

Make markers available to subclasses

c8c7f45

Fix build

3a77fd6

jassmith requested review from jassmith and samhouts September 10, 2018 17:22

jassmith assigned jassmith and samhouts Sep 10, 2018

samhouts added t/enhancement ➕ a/maps 🌐 p/Android labels Sep 11, 2018

samhouts changed the title ~~Make markers available to subclasses~~ [Android Maps] Make markers available to subclasses Sep 11, 2018

samhouts suggested changes Sep 11, 2018

View reviewed changes

Xamarin.Forms.Maps.Android/MapRenderer.cs Outdated Show resolved Hide resolved

Use Find instead of FirstOrDefault

8ca04f7

samhouts approved these changes Sep 11, 2018

View reviewed changes

jassmith approved these changes Sep 17, 2018

View reviewed changes

jassmith merged commit bd31e1e into xamarin:master Sep 17, 2018

adrianknight89 pushed a commit to adrianknight89/Xamarin.Forms that referenced this pull request Sep 24, 2018

[Android Maps] Make markers available to subclasses (xamarin#3751)

b8fc57f

* Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault

adrianknight89 pushed a commit to adrianknight89/Xamarin.Forms that referenced this pull request Sep 28, 2018

[Android Maps] Make markers available to subclasses (xamarin#3751)

e62c26b

* Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault

kingces95 pushed a commit that referenced this pull request Oct 2, 2018

[Android Maps] Make markers available to subclasses (#3751)

17831c9

* Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault

kingces95 pushed a commit that referenced this pull request Oct 2, 2018

[Android Maps] Make markers available to subclasses (#3751)

8a0415f

* Make markers available to subclasses * Fix build * Use Find instead of FirstOrDefault

PureWeen added this to the 3.4.0 milestone Oct 17, 2018

jcmanke mentioned this pull request Nov 5, 2019

Map circles #7401

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android Maps] Make markers available to subclasses #3751

[Android Maps] Make markers available to subclasses #3751

LRP-sgravel commented Sep 9, 2018 •

edited by samhouts

Loading

samhouts left a comment

[Android Maps] Make markers available to subclasses #3751

[Android Maps] Make markers available to subclasses #3751

Conversation

LRP-sgravel commented Sep 9, 2018 • edited by samhouts Loading

Description of Change

Issues Resolved

API Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

Testing Procedure

PR Checklist

samhouts left a comment

Choose a reason for hiding this comment

LRP-sgravel commented Sep 9, 2018 •

edited by samhouts

Loading