New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xaml] move ValueConverterProvider to Core #890

Merged
merged 2 commits into from Apr 28, 2017

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Apr 28, 2017

Description of Change

introducing the ValueConverterProvider created a dependency from Core to Xaml. Moving the files to Core to avoid implicit dependency.

This is probably a regression in 2.3.4 and 2.3.5. Please backport accordingly

Bugs Fixed

API Changes

/

Behavioral Changes

/

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@jassmith jassmith merged commit 8af6f3e into master Apr 28, 2017

1 check passed

Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3780, ignored: 10
Details

@samhouts samhouts deleted the fix-55636 branch May 2, 2017

StephaneDelcroix added a commit that referenced this pull request May 3, 2017

[Xaml] move ValueConverterProvider to Core (#890)
* [Xaml] move ValueConverterProvider to Core

* [docs] fix docs

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request May 12, 2017

Merge branch '2.3.5' into ios-fastrenderers
* 2.3.5:
  [C] fix BP declaring Types for A11y (#913)
  [All] Rename Accessibility -> AutomationProperties (#912)
  Fix build
  [Core] Accessibility works with XamlC (#911)
  Fix bugzilla55542 (#898)
  [Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)
  Give layouts a chance to handle touch events after passing though immediate children (#902)
  Add disposed check on FastRenderer.VisualElemen... (#888)
  [Android] Add disposed check on FastRenderers.LabelRenderer (#886)
  add disposed check on FastRenderers.FrameRenderer (#887)
  [iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
  [Xaml] move ValueConverterProvider to Core (#890)

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment