This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Xaml] move ValueConverterProvider to Core #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
added a commit
that referenced
this pull request
May 3, 2017
* [Xaml] move ValueConverterProvider to Core * [docs] fix docs
assemhakmeh
added a commit
to assemhakmeh/Xamarin.Forms
that referenced
this pull request
May 12, 2017
* 2.3.5: [C] fix BP declaring Types for A11y (xamarin#913) [All] Rename Accessibility -> AutomationProperties (xamarin#912) Fix build [Core] Accessibility works with XamlC (xamarin#911) Fix bugzilla55542 (xamarin#898) [Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (xamarin#899) Give layouts a chance to handle touch events after passing though immediate children (xamarin#902) Add disposed check on FastRenderer.VisualElemen... (xamarin#888) [Android] Add disposed check on FastRenderers.LabelRenderer (xamarin#886) add disposed check on FastRenderers.FrameRenderer (xamarin#887) [iOS] Null Element before disposing trial renderers in uneven ListViews (xamarin#894) [Xaml] move ValueConverterProvider to Core (xamarin#890)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
introducing the ValueConverterProvider created a dependency from Core to Xaml. Moving the files to Core to avoid implicit dependency.
This is probably a regression in 2.3.4 and 2.3.5. Please backport accordingly
Bugs Fixed
API Changes
/
Behavioral Changes
/
PR Checklist