New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Accessibility works with XamlC #911

Merged
merged 4 commits into from May 10, 2017

Conversation

Projects
None yet
3 participants
@samhouts
Member

samhouts commented May 9, 2017

Description of Change

Add the required get/set methods for XamlC to properly parse the Accessibility attached properties.

Bugs Fixed

API Changes

Added:

  • Accessibility.GetHint
  • Accessibility.GetIsInAccessibleTree
  • Accessibility.GetLabeledBy
  • Accessibility.GetName
  • Accessibility.SetHint
  • Accessibility.SetIsInAccessibleTree
  • Accessibility.SetLabeledBy
  • Accessibility.SetName

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas dnfclas added the cla-required label May 9, 2017

@samhouts samhouts requested a review from StephaneDelcroix May 9, 2017

samhouts added some commits May 8, 2017

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix May 9, 2017

Member

rogue white lines can randomly make the build fail. True story.

Member

StephaneDelcroix commented on Xamarin.Forms.Core/Accessibility.cs in 831955e May 9, 2017

rogue white lines can randomly make the build fail. True story.

This comment has been minimized.

Show comment
Hide comment
@samhouts

samhouts May 9, 2017

Member

I've seen it happen.
never again.

Member

samhouts replied May 9, 2017

I've seen it happen.
never again.

@samhouts samhouts referenced this pull request May 9, 2017

Merged

[All] Rename Accessibility -> AutomationProperties #912

4 of 4 tasks complete

@StephaneDelcroix StephaneDelcroix merged commit c1fbfae into master May 10, 2017

8 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
Android-UITests-LegacyRenderers Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 (Legacy Rende…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Debug : Tests passed: 3791, ignored: 10
Details
Windows-Release Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: Windows Release Unit Tests : Tests passed: 3791, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests p…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Stable - Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests pa…
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-bugzilla56079 branch May 10, 2017

rmarinho added a commit that referenced this pull request May 10, 2017

[Core] Accessibility works with XamlC (#911)
* Add unit tests for a11y XAML parsing

* [Core] Add Get/Set methods for XamlC

* Update docs

* Fix rogue blank line

assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request May 12, 2017

Merge branch '2.3.5' into ios-fastrenderers
* 2.3.5:
  [C] fix BP declaring Types for A11y (#913)
  [All] Rename Accessibility -> AutomationProperties (#912)
  Fix build
  [Core] Accessibility works with XamlC (#911)
  Fix bugzilla55542 (#898)
  [Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)
  Give layouts a chance to handle touch events after passing though immediate children (#902)
  Add disposed check on FastRenderer.VisualElemen... (#888)
  [Android] Add disposed check on FastRenderers.LabelRenderer (#886)
  add disposed check on FastRenderers.FrameRenderer (#887)
  [iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
  [Xaml] move ValueConverterProvider to Core (#890)

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment