Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Conversation

@samhouts
Copy link
Contributor

@samhouts samhouts commented May 9, 2017

Description of Change

Add the required get/set methods for XamlC to properly parse the Accessibility attached properties.

Bugs Fixed

API Changes

Added:

  • Accessibility.GetHint
  • Accessibility.GetIsInAccessibleTree
  • Accessibility.GetLabeledBy
  • Accessibility.GetName
  • Accessibility.SetHint
  • Accessibility.SetIsInAccessibleTree
  • Accessibility.SetLabeledBy
  • Accessibility.SetName

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts force-pushed the fix-bugzilla56079 branch from 87e00e2 to 84b1716 Compare May 9, 2017 17:13
Copy link
Member

@StephaneDelcroix StephaneDelcroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@StephaneDelcroix StephaneDelcroix merged commit c1fbfae into master May 10, 2017
@StephaneDelcroix StephaneDelcroix deleted the fix-bugzilla56079 branch May 10, 2017 06:50
rmarinho pushed a commit that referenced this pull request May 10, 2017
* Add unit tests for a11y XAML parsing

* [Core] Add Get/Set methods for XamlC

* Update docs

* Fix rogue blank line
assemhakmeh added a commit to assemhakmeh/Xamarin.Forms that referenced this pull request May 12, 2017
* 2.3.5:
  [C] fix BP declaring Types for A11y (xamarin#913)
  [All] Rename Accessibility -> AutomationProperties (xamarin#912)
  Fix build
  [Core] Accessibility works with XamlC (xamarin#911)
  Fix bugzilla55542 (xamarin#898)
  [Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (xamarin#899)
  Give layouts a chance to handle touch events after passing though immediate children (xamarin#902)
  Add disposed check on FastRenderer.VisualElemen... (xamarin#888)
  [Android] Add disposed check on FastRenderers.LabelRenderer (xamarin#886)
  add disposed check on FastRenderers.FrameRenderer (xamarin#887)
  [iOS] Null Element before disposing trial renderers in uneven ListViews (xamarin#894)
  [Xaml] move ValueConverterProvider to Core (xamarin#890)
@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018
mattleibow pushed a commit that referenced this pull request Jan 28, 2021
* Fixes #911 to use old network checks on older devices

* Update Connectivity.android.cs

* Cleanup build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants