This repository was archived by the owner on May 1, 2024. It is now read-only.
Avoid ImageButtonRenderer ObjectDisposedException on Android #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...yToolkit/Xamarin.CommunityToolkit/Effects/IconTintColor/IconTintColorEffectRouter.android.cs
Outdated
Show resolved
Hide resolved
...yToolkit/Xamarin.CommunityToolkit/Effects/IconTintColor/IconTintColorEffectRouter.android.cs
Outdated
Show resolved
Hide resolved
Comment reference to XF issue
Cfun1
force-pushed
the
Fix-ImageButtonRenderer-Disposed
branch
from
34b690d to
cbfacfa
Compare
AndreiMisiukevich
approved these changes
Feb 28, 2021
jBijsterboschNL
approved these changes
Mar 2, 2021
2 tasks
JoelPickin
pushed a commit
to JoelPickin/XamarinCommunityToolkit
that referenced
this pull request
Mar 16, 2021
…#996) * Avoid crash using reflection or exception ignoring * Remove uncessserary exception reference. Comment reference to XF issue Co-authored-by: Andrei <andrei.misiukevich@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Catching
ObjectDisposedExceptionand ignoring it to avoid a crash.Bugs Fixed
PR Checklist