This repository was archived by the owner on Dec 12, 2024. It is now read-only.
Slightly better asserts. #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spouliot
approved these changes
Sep 24, 2020
| @@ -23,7 +23,7 @@ public void LoadsDatabaseSmokeTest (PlatformName platform, int expectedLowerLimi | |||
| var database = importer.Import (); | |||
| Assert.IsNotNull (database, $"null database for {platform}"); | |||
| Assert.Less (expectedLowerLimit, database.Count, $"Expected at least {expectedLowerLimit} db entries, but got {database.Count} entries."); | |||
| Assert.IsTrue (!errors.AnyErrors, $"{errors.ErrorCount} errors importing database."); | |||
| errors.AssertNoErrors ("errors importing database."); | |||
There was a problem hiding this comment.
an error with $"{errors.ErrorCount} errors while {whileDoing}" and "errors importing database." will give you
"1 errors while errors importing database."
whitneyschmidt
approved these changes
Sep 24, 2020
| @@ -23,7 +23,7 @@ public void LoadsDatabaseSmokeTest (PlatformName platform, int expectedLowerLimi | |||
| var database = importer.Import (); | |||
| Assert.IsNotNull (database, $"null database for {platform}"); | |||
| Assert.Less (expectedLowerLimit, database.Count, $"Expected at least {expectedLowerLimit} db entries, but got {database.Count} entries."); | |||
| Assert.IsTrue (!errors.AnyErrors, $"{errors.ErrorCount} errors importing database."); | |||
| errors.AssertNoErrors ("importing database."); | |||
There was a problem hiding this comment.
Sanity check - would it make sense to make the "importing database" a constant for these tests?
There was a problem hiding this comment.
Sure! PRs welcome! 😄
chamons
approved these changes
Sep 24, 2020
mandel-macaque
approved these changes
Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly better. Addressing this issue.
Past me clearly thought that this was going to be used more often than it is, but it's not fully YAGNI (you ain't gonna need it).
Future me may yet be grateful for past me's foresight.