[msbuild] Sign Xamarin.iOS.Tasks.dll and Xamarin.Mac.Tasks.dll. Fixes #9835. #12831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks.dll. This is required for strong-naming to work properly (otherwise all assemblies will have the same version).
…amarin#9835. We need to strongname our MSBuild assemblies, so that different versions can be loaded side-by-side (one example being having both a legacy and a .NET project in the same solution). This also required signing the corresponding test assemblies, since they poke into the internals of the task assemblies. Fixes xamarin#9835.
chamons
approved these changes
Sep 24, 2021
dalexsoto
approved these changes
Sep 24, 2021
mandel-macaque
approved these changes
Sep 24, 2021
|
|
||
| [assembly: AssemblyCompanyAttribute ("Microsoft Corp.")] | ||
| [assembly: AssemblyFileVersionAttribute (VersionConstants.XamarinMacVersion)] | ||
| [assembly: AssemblyInformationalVersionAttribute (VersionConstants.XamarinMacVersion + "." + VersionConstants.NuGetPrereleaseIdentifier + "+" + VersionConstants.NuGetBuildMetadata)] |
There was a problem hiding this comment.
I would have prefer string interpolation ;)
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 136 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2414). |
mauroa
reviewed
Sep 27, 2021
Yes, I think it would be a good idea. I think that can be done in a different PR though. |
mauroa
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to strongname our MSBuild assemblies, so that different versions
can be loaded side-by-side (one example being having both a legacy and a
.NET project in the same solution).
This required setting a version for Xamarin.iOS.Tasks.dll and
Xamarin.Mac.Tasks.dll, otherwise strong-naming won't work properly (all
versions of an assembly would have the same identity).
Also sign the corresponding test assemblies, since they poke into the
internals of the task assemblies.
Fixes #9835.