Fix #9996 and #15622

[janwiebe-jump]

As discussed in #9996 the CPListSection constructors are not fully correct, since the CPListImageRowItem can't be added to it, which is possible in the native iOS SDK.
This PR fixes that. With that, also #15622 seems to be fixed.

[mandel-macaque]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mandel-macaque]

I believe we need to Obsolete and leave the old ones while providing a path for users to upgrade rather that break the API. Nevertheless I have triggered the build to confirm the API will be broken.

[mandel-macaque]

@janwiebe-jump Thanks for the fix! I have some small concerts which I left in the review.

[janwiebe-jump]

Thanks @mandel-macaque , good catch indeed.
I re-added the old constructors, and added the Obsolete attribute.
Next to that, I also added the Items[] property (besides the existing) to conform to the iOS api.

[mandel-macaque]

We still need to wrap the old api with a #if so that next time we have the chance to break APIs we do not expose something wrong :)

[mandel-macaque]

Lets see what the tests got to see. But the changes look good to me.

[mandel-macaque]

/azp run

[janwiebe-jump]

Hmm, the Items property

Lets see what the tests got to see. But the changes look good to me.

Thanks. I am curious how the duplicate Items[] works out

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mandel-macaque]

@janwiebe-jump I suspect is going to fail, but it an easy fix (ugly, but doable). I'll keep an eye as according tot he failures I might propose a code change.

[mandel-macaque]

/azp run

[dalexsoto]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dalexsoto]

Looks like our CI is having a hard time :(

[rolfbjarne]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rolfbjarne]

It doesn't compile:

build/dotnet/ios/generated-sources/CarPlay/CPListSection.g.cs(387,42): error CS8115: A throw expression is not allowed in this context.
build/dotnet/ios/generated-sources/CarPlay/CPListSection.g.cs(387,48): error CS0039: Cannot convert type 'System.InvalidOperationException' to 'Foundation.NSArray' via a reference conversion, boxing conversion, unboxing conversion, wrapping conversion, or null type conversion
make[1]: *** [build/dotnet/ios/32/Microsoft.iOS.dll] Error 1

[dalexsoto]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vs-mobiletools-engineering-service2]

🔥 Failed to compare API and create generator diff 🔥

Error: 'make' failed for the hash 1f12270.

Pipeline on Agent
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.349-ci.pr.gh15642.pkg
• Microsoft.iOS.Ref.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Sdk.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Templates.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.349-ci.pr.gh15642.pkg
• Microsoft.MacCatalyst.Ref.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.MacCatalyst.Templates.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.macOS.Bundle.12.3.349-ci.pr.gh15642.pkg
• Microsoft.macOS.Ref.12.3.349-ci.pr.gh15642.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.349-ci.pr.gh15642.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.349-ci.pr.gh15642.nupkg
• Microsoft.macOS.Sdk.12.3.349-ci.pr.gh15642.nupkg
• Microsoft.macOS.Templates.12.3.349-ci.pr.gh15642.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-6.0.300.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-6.0.300.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-6.0.300.12.3.349-ci.pr.gh15642.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-6.0.300.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.NET.Workload.iOS.15.4.349-ci.pr.gh15642.msi
• Microsoft.tvOS.Bundle.15.4.349-ci.pr.gh15642.pkg
• Microsoft.tvOS.Ref.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.tvOS.Sdk.15.4.349-ci.pr.gh15642.nupkg
• Microsoft.tvOS.Templates.15.4.349-ci.pr.gh15642.nupkg
• xamarin.ios-15.13.0.45.pkg
• xamarin.mac-8.13.0.45.pkg

Pipeline on Agent XAMBOT-1109.Monterey'
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

[vs-mobiletools-engineering-service2]

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

• introspection
• xammac_tests
• monotouch-test

Pipeline on Agent
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

[rolfbjarne]

Thanks a lot for your help!

[janwiebe-jump]

Hi @rolfbjarne,
Thanks a lot, also for your ant the team's assistance!
Will this also be released as a xamarin-ios version that I can use in my Xamarin iOS (Forms) app? We can't yet move to MAUI / .NET 6, due to a lot of dependencies, so I would strongly prefer a xamarin-ios.pkg version with this fix included, so we can release our CarPlay app.
Thanks so much!

[rolfbjarne]

@janwiebe-jump yes, this will be released in a xamarin-ios.pkg (when we release support for Xcode 14, the packages will contain your fix)