-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NaturalLanguage] Updates for Xcode14 Beta 2 #15718
[NaturalLanguage] Updates for Xcode14 Beta 2 #15718
Conversation
@@ -26,6 +26,13 @@ public void Vector () | |||
if (v == NLLanguage.Unevaluated) | |||
continue; // this is not a value provided by Apple. | |||
|
|||
switch (v){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should be switch (v) {
also CheckXcodeVersion (14, 0))`(spacing)
Larger question - are you expecting this to grow beyond the 1 case in the switch? Otherwise why not:
if (v == NLLanguage.Kazakh && !TestRuntime.CheckXcodeVersion (14, 0))
continue;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephen-hawley Good call on the style!
Yes, I believe that anytime a new language is added in the future xcode versions, we will need a new CheckXcodeVersion (X, X) since the test will attempt to call those languages with previous OS versions and fail the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephen-hawley Spacing on the switch addressed! I am not sure about the "also CheckXcodeVersion (14, 0))`(spacing)" but let me know if you would like something else there addressed as well!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 5 tests failed, 223 tests passed. Failures❌ introspection tests
Html Report (VSDrops) Download ❌ monotouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.