Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIKit] Add nullability to file #15857

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Conversation

haritha-mohan
Copy link
Contributor

File did not have nullability enabled. Add nullability and made some changes to code as safeguards.

@haritha-mohan haritha-mohan added the not-notes-worthy Ignore for release notes label Sep 2, 2022
src/UIKit/UIGestureRecognizer.cs Outdated Show resolved Hide resolved
src/UIKit/UIGestureRecognizer.cs Outdated Show resolved Hide resolved
src/UIKit/UIGestureRecognizer.cs Outdated Show resolved Hide resolved
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as long as the changes requested by @rolfbjarne are done.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

src/UIKit/UIGestureRecognizer.cs Show resolved Hide resolved
src/UIKit/UIGestureRecognizer.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

@haritha-mohan
Copy link
Contributor Author

Didn't catch a build issue, will commit working version once fixed

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 8e7c67fcfd0d2b29610572ea3d67f61e3ab6685b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1042.Monterey'
Hash: 8e7c67fcfd0d2b29610572ea3d67f61e3ab6685b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 8e7c67fcfd0d2b29610572ea3d67f61e3ab6685b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 8e7c67fcfd0d2b29610572ea3d67f61e3ab6685b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 4 tests failed, 219 tests passed.

Failures

❌ linker tests

2 tests failed, 63 tests passed.
  • dont link/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
  • link sdk/iOS Unified 64-bits - simulator/Debug: LaunchFailure

Html Report (VSDrops) Download

❌ monotouch tests

1 tests failed, 22 tests passed.
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): TimedOut

Html Report (VSDrops) Download

❌ msbuild tests

1 tests failed, 1 tests passed.
  • MSBuild tests/Tasks: BuildFailure

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@mandel-macaque
Copy link
Member

Tests failures:

  • Linker tests fail in just a single configuration and is not related to the change.
  • MSBuild tests fail due to a network issue when fetching nugets.

None are related with the change.

@mandel-macaque mandel-macaque merged commit 35cb9ac into xamarin:main Sep 7, 2022
@mandel-macaque
Copy link
Member

/sudo backport xcode14

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch xcode14 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6658871 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants