New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Adopt the 1ES template #20204

Closed

mandel-macaque wants to merge 57 commits into main from 1es-template

Member

mandel-macaque commented Feb 26, 2024 •

edited

Loading

There are a number of changes that were needed:

Use 1ES approved images. We moved all the windows-latests images to a 1ES image and moved all ubuntu ones to windows.
Update the tasks that do the uploads. 1ES provides a new task and will fail if other one is used.
Removed the workspace clean directive. Is not really needed and it confused the template.
Configured all the governance checks to be run by the template. Removed our own implementation of those tasks except for APIScan which is not included in the template.

Setting to draft since we need our macOS pools to be approved else the 1ES template test will fail and not run the jobs.

mandel-macaque added 18 commits

February 26, 2024 13:17


          [CI] Onboard with 1ES.

2258ec8


          Move awauy from PublishBuildArtifacts@1 to complay with 1ES.

ccc58e7


          Adapt to the params of the new task.

07e04ed


          Move more tasks to the new one.

52750ca


          Use the new param needed for the sign to work with 1es.

180de21


          Change missing task.

a4fb4b9


          Try to fix the execution by providing a pool name.

30c9ef5


          Add references to workspace because the 1es template does not know ho…

c30652f

…w to handle them.


          Move away from not allowed task.

db956c0


          List the repos to scan.

aaa9a50


          Provide the pool to use for the sdl.

564f191


          Repositories are objs not strings.

bbed2fc


          Move all images to 1es complient images.

9ff6c81


          Run the scan in the same job to access the supression files.

83523e9


          Configure policheck.

8a4d230


          Do not use debug mode.

de936d0


          Remove not needed yaml.

e19e570


          Merge branch 'main' into 1es-template

a69fe1d

This comment has been minimized.

Sign in to view

rolfbjarne changed the title ~~[CI] Adapt the 1ES template~~ [CI] Adopt the 1ES template

mandel-macaque added 6 commits

February 28, 2024 09:08


          Bump maccore and point to the baselines to get a green build.

215b69d


          Use the 1es task in the nuget convert task.

20bf93b


          Use the 1es tasks to push nugets.

235db66


          Deal with baseline and supressions properly.

3995d69


          1ES needs to know the OS to validate the pool.

116da41


          IS baselineFile not baseFile.

9a57369

mandel-macaque marked this pull request as ready for review

February 28, 2024 17:12

mandel-macaque requested a review from rolfbjarne as a code owner

February 28, 2024 17:12


          Fix indentation yamllint complains.

36a72e4

rolfbjarne approved these changes

View reviewed changes

tools/devops/automation/templates/build/build-pkgs.yml

Comment on lines +83 to +84

		path: $(Build.SourcesDirectory)/WorkloadRollback.json
		artifact: '${{ parameters.uploadPrefix }}WorkloadRollback'

Member

rolfbjarne Feb 28, 2024

They could have reused the same names :/ Would have made our diff much smaller.

Member Author

mandel-macaque Feb 28, 2024

Trust me, I have rant about this.

Contributor

mcumming May 16, 2024

They are the same if you use the templateContext.outputs, maybe it was intentional to make you move to that format? evil geniuses?

tools/devops/automation/templates/release/vs-insertion-prep.yml

		nuGetFeedType: external
		publishFeedCredentials: dnceng-dotnet8

Member

rolfbjarne Feb 28, 2024

Which feed do we publish to now? It doesn't look like that's chosen anywhere.

Member Author

mandel-macaque Feb 28, 2024

yeah, I requested a force insert to check that

This comment has been minimized.

Sign in to view

mandel-macaque added 2 commits

April 23, 2024 11:17


          Add config file, yet it should not be needed. Is a 1ES bug.

7f75494


          Merge branch 'main' into 1es-template

302e811

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

mandel-macaque added 3 commits

April 23, 2024 13:42


          Always get the diagnostics.

17f5779


          Use the artifacts staging dir which gets automatically cleaned.

47cd8bf


          Co maccore for the sign and notarize templates.

dc4a918

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          Use the correct dit for the artifacts.

This comment has been minimized.

Sign in to view

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 20178631edd9974bba890def574b1de2e237606e [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 20178631edd9974bba890def574b1de2e237606e [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented Apr 23, 2024

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 170 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 20178631edd9974bba890def574b1de2e237606e [PR build]

mandel-macaque closed this

mandel-macaque deleted the 1es-template branch

June 21, 2024 16:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet