Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HomeKit][Xcode12] Update for beta 3 #9270

Merged
merged 2 commits into from
Aug 7, 2020
Merged

[HomeKit][Xcode12] Update for beta 3 #9270

merged 2 commits into from
Aug 7, 2020

Conversation

whitneyschmidt
Copy link
Contributor

@whitneyschmidt whitneyschmidt commented Aug 4, 2020 •
edited
Loading

I'm not sure why these enums weren't added or picked up before.

do-not-merge added until beta 4 updates are added.

@whitneyschmidt whitneyschmidt added this to the xcode12 milestone Aug 4, 2020
@whitneyschmidt whitneyschmidt changed the title [HomeKit][Xcode12] Update for beta [HomeKit][Xcode12] Update for beta 3 Aug 4, 2020
@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

mandel-macaque
mandel-macaque requested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that this is correct for beta 4.

src/HomeKit/HMEnums.cs Outdated
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noise.

@whitneyschmidt whitneyschmidt added the do-not-merge Do not merge this pull request label Aug 5, 2020
@whitneyschmidt whitneyschmidt removed the do-not-merge Do not merge this pull request label Aug 5, 2020
@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 75 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed

@whitneyschmidt
Copy link
Contributor Author

build

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@whitneyschmidt whitneyschmidt merged commit 205412f into xamarin:xcode12 Aug 7, 2020
@whitneyschmidt whitneyschmidt added iOS Issues affecting iOS note-highlight Worth calling out specifically in release notes labels Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque requested changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto Awaiting requested review from dalexsoto

@spouliot spouliot Awaiting requested review from spouliot

Assignees
No one assigned
Labels
iOS Issues affecting iOS note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode12
Development

Successfully merging this pull request may close these issues.
4 participants
@whitneyschmidt @monojenkins @rolfbjarne @mandel-macaque