Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreLocation] Update framework to Xcode 12 beta 3. #9281

Merged

Conversation

mandel-macaque
Copy link
Member

No description provided.

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update to beta 4 ;)

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@mandel-macaque
Copy link
Member Author

Removed methods from the header diff:

-// These methods will be removed entirely before GM ships.  Please migrate to the final naming of the API!
-/*
- *  requestTemporaryPreciseLocationAuthorizationWithPurposeKey:completion:
- *
- *  Discussion:
- *      Do not use
- */
-- (void)requestTemporaryPreciseLocationAuthorizationWithPurposeKey:(NSString *)purposeKey completion:(void(^ _Nullable)(NSError * _Nullable))completion API_DEPRECATED_WITH_REPLACEMENT("-requestTemporaryAccurateLocationAuthorizationWithPurposeKey:completion:", ios(14.0, 14.0), macos(10.16, 11.0), watchos(7.0, 7.0), tvos(14.0, 14.0));
-/*
- *  requestTemporaryPreciseLocationAuthorizationWithPurposeKey:
- *
- *  Discussion:
- *      Do not use
- */
-- (void)requestTemporaryPreciseLocationAuthorizationWithPurposeKey:(NSString *)purposeKey API_DEPRECATED_WITH_REPLACEMENT("-requestTemporaryAccurateLocationAuthorizationWithPurposeKey:", ios(14.0, 14.0), macos(10.16, 11.0), watchos(7.0, 7.0), tvos(14.0, 14.0));
-/*
- *  authorizedForPreciseLocation:
- *
- *  Discussion:
- *      Do not use
- */
-@property (nonatomic, readonly, getter=isAuthorizedForPreciseLocation) BOOL authorizedForPreciseLocation API_DEPRECATED_WITH_REPLACEMENT("-accuracyAuthorization", ios(14.0, 14.0), macos(10.16, 11.0), watchos(7.0, 7.0), tvos(14.0, 14.0));
-

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

2 tests failed, 74 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: TimedOut
  • framework-test/watchOS 32-bits - simulator/Debug: TimedOut

@mandel-macaque
Copy link
Member Author

build

@dalexsoto dalexsoto added the note-highlight Worth calling out specifically in release notes label Aug 7, 2020
@dalexsoto dalexsoto added this to the xcode12 milestone Aug 7, 2020
@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@mandel-macaque mandel-macaque merged commit 50931c6 into xamarin:xcode12 Aug 7, 2020
@mandel-macaque mandel-macaque deleted the corelocation-xcode12-beta3 branch August 7, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants