Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xcode12][NearbyInteraction] New framework, updated through beta 4 #9336

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

whitneyschmidt
Copy link
Contributor

@whitneyschmidt whitneyschmidt commented Aug 7, 2020

See https://github.com/xamarin/maccore/issues/2274 - added to Xcode 12 checklist as well.

Update for manual binding: #9346

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 78 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@@ -68,6 +68,13 @@ protected virtual bool Skip (Type type)
return true;
case "NEPacketTunnelProvider":
return true;
// On iOS 14 (beta 4) we get: [NISimulator] To simulate Nearby Interaction distance and direction, launch two or more simulators and
// move the simulator windows around the screen.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a great reason to request a bigger screen 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@whitneyschmidt whitneyschmidt Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Looking for bigger apartment listings to accommodate an 86" monitor or two....

@mandel-macaque
Copy link
Member

@whitneyschmidt failure is unrelated, looks like https://github.com/xamarin/maccore/issues/1028 I believe we are ok to merge the PR.

@whitneyschmidt whitneyschmidt merged commit 6ff4eb6 into xamarin:xcode12 Aug 10, 2020
Comment on lines +18 to +24
[NoWatch, NoTV, NoMac, iOS (14, 0)]
[Static]
interface NIErrorDomain
{
[Field ("NIErrorDomain")]
NSString Domain { get; }
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in the NIErrorCode error enum like this

[iOS (11,0)]
[Mac (10,15)]
[ErrorDomain ("FPUIErrorDomain")]
[Native]
enum FPUIExtensionErrorCode : ulong {
UserCancelled,
Failed
}

@whitneyschmidt whitneyschmidt added note-highlight Worth calling out specifically in release notes iOS Issues affecting iOS labels Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues affecting iOS note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants