tap-clt: Improve list output filtering #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSymsCtx
previously approved these changes
Apr 25, 2023
|
Minor niggle of a typo in the commit message |
tap-ctl list is returning the allocated but unattached tapdevs when used
with -t and -f. We want to skip those since they don't match.
Full output:
$ tap-ctl list
334529 1 0 vhd /home/user/test.vhd
334534 2 0 aio /home/user/test.aio
- 0 - - -
Filtered before this change:
$ tap-ctl list -t vhd -f /home/user/test.vhd
334529 1 0 vhd /home/user/test.vhd
- 0 - - -
Filtered after this change:
$ tap-ctl list -t vhd -f /home/user/test.vhd
334529 1 0 vhd /home/user/test.vhd
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
jandryuk
force-pushed
the
list-filtering
branch
from
a12e0b5 to
bc7a826
Compare
|
Thanks, @MarkSymsCtx . Fixed the typo. |
MarkSymsCtx
approved these changes
May 2, 2023
TimSmithCtx
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tap-ctl list is returning the allocated but unattached tapdevs when used with -t and -f. We want to skip those since they don't match.
Full output:
$ tap-ctl list
334529 1 0 vhd /home/user/test.vhd
334534 2 0 aio /home/user/test.aio
- 0 - - -
Filtered before this change:
$ tap-ctl list -t vhd -f /home/user/test.vhd
334529 1 0 vhd /home/user/test.vhd
- 0 - - -
Filtered after this change:
$ tap-ctl list -t vhd -f /home/user/test.vhd
334529 1 0 vhd /home/user/test.vhd