Move quicktest_encodings from xapi into a unit test #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
mseri
reviewed
Apr 12, 2018
| - PINS="stdext:. xapi-stdext:. xapi-stdext-base64:. xapi-stdext-bigbuffer:. xapi-stdext-date:. xapi-stdext-deprecated:. xapi-stdext-encodings:. xapi-stdext-monadic:. xapi-stdext-pervasives:. xapi-stdext-range:. xapi-stdext-std:. xapi-stdext-threads:. xapi-stdext-unix:. xapi-stdext-zerocheck:." | ||
| - DISTRO="centos-7" | ||
| - TESTS=false | ||
| - DISTRO="ubuntu-16.04" |
There was a problem hiding this comment.
I really would like to keep centos-7... We should rethink our whole CI to use xs-opam:latest as a base...
There was a problem hiding this comment.
It does not work because it was impossible to isntall the real aspcud in the docker image, even POST_INSTALL_HOOK didn't work :(
There was a problem hiding this comment.
Yes, I understand. I am still wishful
mseri
reviewed
Apr 12, 2018
| matrix: | ||
| - PACKAGE=xapi-stdext OCAML_VERSION=4.04.2 REVDEPS=true | ||
| - PACKAGE=xapi-stdext OCAML_VERSION=4.04.2 REVDEPS=true \ | ||
| POST_INSTALL_HOOK="opam install alcotest; env TRAVIS=$TRAVIS TRAVIS_JOB_ID=$TRAVIS_JOB_ID bash -ex coverage.sh" |
There was a problem hiding this comment.
Are we sure about discovering the coverage of this library... ;-)
There was a problem hiding this comment.
It will be 99% because we only track stdext-encodings :D
mseri
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a quicktest in xapi, but in fact it unit tests Xapi_stdext_encodings, so it belongs here.
Signed-off-by: Gabor Igloi gabor.igloi@citrix.com