Don't collect stats for loopback and bond devices #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use the stats for these devices, so lets not spend time on them. Furthermore, due to the fact that the Sysfs.read_one_line and therefore the Sysfs.get_pci_ids function now log errors, and the loopback and bond devices do not have PCI info in sysfs, this was causing lots of log spam. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
robhoes
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use the stats for these devices, so lets not spend time on them.
Furthermore, due to the fact that the Sysfs.read_one_line and therefore the
Sysfs.get_pci_ids function now log errors, and the loopback and bond devices
do not have PCI info in sysfs, this was causing lots of log spam.
Signed-off-by: Rob Hoes rob.hoes@citrix.com