Change monitor blacklist into whitelist #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we have tighter control over what interfaces are monitored, which are essentially just PIFs (eth*) and VIFs (vifx.y). Recently, we have had to extend the blacklist several times, because devices with different names appeared, which we do not want to monitor. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
lindig
approved these changes
Oct 10, 2016
networkd/network_monitor_thread.ml
Outdated
| let is_monitor_blacklisted = List.exists (fun s -> String.startswith s name) !monitor_blacklist || | ||
| (String.startswith "eth" name && String.contains name '.') in | ||
| not is_monitor_blacklisted | ||
| List.exists (fun s -> String.startswith s name) !monitor_whitelist |
There was a problem hiding this comment.
It is simple enough but I would find creating two predicates even clearer: is_whitelisted and is_vlan and then use List.filter (fun (name,_) -> is_whitelisted name && not (is_vlan name)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we have tighter control over what interfaces are monitored, which are
essentially just PIFs (eth*) and VIFs (vifx.y). Recently, we have had to extend
the blacklist several times, because devices with different names appeared,
which we do not want to monitor.
Signed-off-by: Rob Hoes rob.hoes@citrix.com