Fix connection leak in Lwt client #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close the connection that we open in the rpc function returned by Xen_api_lwt_unix.make. Since the Xen_api_lwt_unix module itself does not expose functions for creating, using, and closing connections, the user would was not able to close the connections created by this rpc function. Previously it opened a new connection for every request that it did not close - this resulted in leaking open connections on the client side and open file descriptors on the xapi side, which can cause the client and/or xapi to fail after a large number of requests. With this commit the behaviour of the Lwt bindings will be the same as the behaviour of the Unix bindings in the xapi-client ocamlfind package provided by xapi: a new connection will be opened and closed for each XenAPI call. I've added the call to disconnect to the rpc function returned by the Lwt library, and not directly to the rpc function in lib/xen_api.ml, because the core library in lib/ supports reusing connections for multiple RPC calls, therefore that rpc function should not close the connection. Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
gaborigloi
changed the title
|
I've tested the fixed library with the repro in #45 , and it didn't leak any file descriptors in xapi, the fd count remained constant after 1000 connects & disconnects. |
|
Apparently the Async-based client has the same issue - I'll repro it and send a PR once this one is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update the .gitignore.
Fixes #45
Fixes #31