CA-255099: Fix firstboot management.conf during Pool.eject #3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write the firstboot parameters with values in single quote. This must align with `xe-reset-networking` and `host installer` updating management.conf This will fix xe-reset-networking to take default vlan value correctly, tried after Pool.eject Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
Use strip() rather than string indexing to read params from management.conf file Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
|
Changes Unknown when pulling cec8fc1 on sharady:CA-255099 into ** on xapi-project:tagged-vlan**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.