Skip to content

Simplify & speed up data_destroy timing tests #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2018
Merged

Simplify & speed up data_destroy timing tests #3463

merged 1 commit into from
Feb 26, 2018

Conversation

gaborigloi
Copy link
Contributor

Signed-off-by: Gabor Igloi gabor.igloi@citrix.com

@coveralls
Copy link

coveralls commented Feb 21, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 17.613% when pulling ad6df33 on gaborigloi:data_destroy_test into ea73037 on xapi-project:master.

minishrink
minishrink approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@minishrink minishrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though it might be worth adding a comment to explain the specific timings you've added (i.e. raising timeout by 1 second).

@gaborigloi
Simplify & speed up data_destroy timing tests
3b1220d 
Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
@gaborigloi gaborigloi merged commit ca5e069 into xapi-project:master Feb 26, 2018
@gaborigloi gaborigloi deleted the data_destroy_test branch February 26, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@minishrink minishrink minishrink approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaborigloi @coveralls @minishrink