[From REQ-477] Cherry-pick a few miscellaneous changes #3471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rebase |
The `with_pool_operation` function, which handles the concurrency of the pool's operations, has been moved to Xapi_pool_helpers to make it easily testable via unit tests. Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com> Note: The implementation of `with_pool_operation` in Xapi_pool_helpers changes slightly to reflect the new Datamodel layout. Signed-off-by: Callum McIntyre <callum.mcintyre@citrix.com>
This module is not used from anywhere, and has no startup code, so drop the dead code. It is confusing having so many rpc functions, especially if we also have ones that are never called. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
set_name_label and _description are supposed to work as follows for SMAPIv3:
1) XAPI calls SR.set_name_label on the SR plugin
2) XAPI calls SR.stat on the SR plugin
3) XAPI updates it's DB with the name/description received back in SR.stat
(This is so the SR plugin has a chance to trim the name,
to be restricted to a certain length or so. And so that the XAPI DB
and the SR plugin are in sync.)
This commit fixes step 3.
Signed-off-by: Robert Breker <robert.breker@citrix.com>
Useful for debugging the new corosync based HA scripts. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
edwintorok
force-pushed
the
CP-26970-master-misc
branch
from
bb88405 to
26d3d49
Compare
mseri
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_pool_operationto be easily testableThe first commit needed a small fix due to the change in Datamodel, the others applied cleanly.