Rearrange main executables and tests #3472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborigloi
reviewed
Feb 23, 2018
ocaml/xapi/jbuild
Outdated
| (flags (:standard -bin-annot %s -warn-error +a-3-4-6-9-27-28-29-52)) | ||
| (modules (:standard \ xapi_main quicktest)) | ||
| (libraries ( | ||
| alcotest |
There was a problem hiding this comment.
Can we also remove this?
gaborigloi
approved these changes
Feb 23, 2018
|
Rebased on top of #3468.
|
gaborigloi
approved these changes
Feb 23, 2018
robhoes
reviewed
Feb 26, 2018
| (action (run ${<})) | ||
| ) | ||
| ) | ||
| |} (flags rewriters) coverage_rewriter |
There was a problem hiding this comment.
Only for coverage, as far as I know.
There was a problem hiding this comment.
So I think we could remove flags.
There was a problem hiding this comment.
It is still needed until we port rpc to jbuilder. A port is ready but there are some issues with camlp4 and the way it interacts with ppx in xapi-idl, so I'd rather wait until the port is complete
minishrink
approved these changes
Feb 27, 2018
added 11 commits
February 27, 2018 10:27
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
includes exporting the xapi library as an internal (and not installed) xapi_internal library Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
|
I've rebased to avoid the conflicts. I am going to merge this if Travis is happy |
|
The xenserver-build-env failure is due to idl changes not yet propagated. The Travis build with xs-opam has successfully passed. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the executables and tests in different scopes, reorganising and clarifying the dependencies.
This is a first step, further improvements will be to further refine the dependencies among those folders and replace
stdextwith the appropriatexapi-stdext-submodules.