Fix release info for domain_type fields #3488
Conversation
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
| field ~qualifier:StaticRO ~ty:domain_type ~lifecycle:[Published, rel_jura, ""] ~default_value:(Some (VEnum "unspecified")) "domain_type" "The type of domain that will be created when the VM is started"; | ||
| field ~qualifier:StaticRO ~ty:domain_type | ||
| ~lifecycle:[ | ||
| Prototyped, rel_jura, "Internal-only field; not yet in the public API"; |
There was a problem hiding this comment.
in datamodel.ml this field is Published, this one is Prototyped. Is that intended?
There was a problem hiding this comment.
I did it this way, because the VM.domain_type field was part of the datamodel in jura, but it was marked as internal_only, and therefore not visible in the external API. Therefore, "published" in kolkata. The VM_metrics.current_domain_type was also includes in jura, but not internal_only, and I had therefore marked it as "published" in jura already (I wanted to also make this field internal, but somehow the datamodel didn't allow this).
However, even VM_metrics.current_domain_type wasn't actually useful in jura, because we never set it to anything other than unspecified. Perhaps it is better to call it "prototyped" as well for this reason.
There was a problem hiding this comment.
Submitted a fixup for this.
|
Yes, this is just for the docs. |
Signed-off-by: Rob Hoes rob.hoes@citrix.com