CA-285349: Reindent Xapi #3506
Closed
CA-285349: Reindent Xapi #3506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
minishrink
force-pushed
the
feature/REQ477/CA-285349/reindent
branch
from
4b9355e to
91c8286
Compare
|
I don't think this is a good idea as long as other feature branches are outstanding. It will make merging them potentially much harder. |
lindig
requested changes
Mar 12, 2018
|
I agree that it is not to right time to do this. We should at least wait for the |
|
Closing until a more suitable time when outstanding feature branches have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reindentation of the entire xapi repo, as decided in the GFS2 PR review meeting.
Note: this PR only includes .ml and .mli files, not .mll or .mly
Signed-off-by: Akanksha Mathur akanksha.mathur@citrix.com