CA-285349: split unplug_all_pbds into two internal functions
#3508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
requested changes
Mar 13, 2018
ocaml/xapi/xapi_pbd.ml
Outdated
| If anything fails it throws an exception *) | ||
| let unplug_all_pbds ~__context = | ||
| unplug_all_pbds_internal ~__context; | ||
| disable_clustering ~__context |
There was a problem hiding this comment.
Please change all the caller of unplug_all_pbds to call these two functions instead. The reason behind splitting the function was to make it clearer what it does: a function called unplug_all_pbds also disabling clustering is somewhat unexpected.
minishrink
force-pushed
the
feature/REQ477/CA-285349/unplug_all_pbds
branch
from
4f6b762 to
86e9f53
Compare
…able clustering Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
minishrink
force-pushed
the
feature/REQ477/CA-285349/unplug_all_pbds
branch
from
86e9f53 to
a9f20b1
Compare
edwintorok
reviewed
Mar 13, 2018
…ost.{ml, mli}
- Remove disable_clustering from Xapi_pbd
- Add disable_clustering to Xapi_cluster_host.{ml, mli}
- Update call to Xapi_pbd.unplug_all_pbds to use
Xapi_pbd.unplug_all_pbds, then
Xapi_cluster_host.disable_clustering
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
|
Moved |
edwintorok
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the GFS2 PR review, this change splits
Xapi_pbd.unplug_all_pbdsinto two separate internal functions; one to unplug all PBDs and one to disable clustering, allowing for better decoupling of these functions. The externalXapi_pbds.unplug_all_pbdsinterface and logic is unchanged.Signed-off-by: Akanksha Mathur akanksha.mathur@citrix.com